Re: [PATCH v1] pinctrl: qcom: lpass-lpi: drop unused runtime-PM write helper

[Krzysztof Kozlowski <krzk@kernel.org>]

On 10/06/2026 10:08, Ajay Kumar Nandam wrote:
> lpi_gpio_write() became unused after the PM clock runtime conversion
> switched write paths to __lpi_gpio_write() inside callers that already
> hold an active runtime-PM reference.
> 
> With -Werror this triggers:
>   error: 'lpi_gpio_write' defined but not used [-Wunused-function]
> 
> Remove the dead wrapper.
> 
> Fixes: b719ede389d8 ("pinctrl: qcom: lpass-lpi: Switch to PM clock framework for runtime PM")

Please add Reported-by credits, at least Nathan as he bisected it.


> Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
> ---
>  drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
> index 4d758fd117c4..fe7ec0176081 100644
> --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
> +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
> @@ -79,20 +79,6 @@ static int lpi_gpio_read(struct lpi_pinctrl *state, unsigned int pin,
>  	return pm_runtime_put_autosuspend(state->dev);
>  }
>  
> -static int lpi_gpio_write(struct lpi_pinctrl *state, unsigned int pin,
> -			  unsigned int addr, unsigned int val)

So why do we need __lpi_gpio_write()?

Best regards,
Krzysztof