From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linusw@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] pinctrl: qcom: lpass-lpi: drop unused runtime-PM write helper
Date: Wed, 10 Jun 2026 11:00:09 +0200 [thread overview]
Message-ID: <f77f6d28-b3fa-46f3-a6c1-fd0093cbb458@kernel.org> (raw)
In-Reply-To: <0fc4d9d4-2943-4ed8-a8ea-014e83c74e5c@oss.qualcomm.com>
On 10/06/2026 10:57, Ajay Kumar Nandam wrote:
>> So why do we need __lpi_gpio_write()?
>
> Hi Krzysztof,
>
> Thanks, good point.
>
> I will respin with:
> Reported-by: Nathan Chancellor <nathan@kernel.org>
And checkpatch.
>
> About __lpi_gpio_write(): it is still needed for the in-callers path
> where runtime PM is already held and we only need the raw MMIO helper.
> The unused wrapper is lpi_gpio_write(), so this fix removes only that
> dead function.
No. Why did you have to add __ prefix? Why do we need function named
with such style?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-06-10 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 8:08 Ajay Kumar Nandam
2026-06-10 8:25 ` Krzysztof Kozlowski
2026-06-10 8:57 ` Ajay Kumar Nandam
2026-06-10 9:00 ` Krzysztof Kozlowski [this message]
2026-06-10 9:14 ` Ajay Kumar Nandam
2026-06-10 18:11 ` Ajay Kumar Nandam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f77f6d28-b3fa-46f3-a6c1-fd0093cbb458@kernel.org \
--to=krzk@kernel.org \
--cc=ajay.nandam@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®