From: Hans de Goede <hdegoede@redhat.com>
To: Darren Hart <dvhart@infradead.org>
Cc: Andy Shevchenko <andy@infradead.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: silead_dmi: Add touchscreen info for I.T.Works TW891 2-in-1
Date: Fri, 7 Jul 2017 13:03:07 +0200 [thread overview]
Message-ID: <f04d821a-866f-0213-e9e8-b83da6b136a3@redhat.com> (raw)
In-Reply-To: <20170706223915.GA19728@fury>
Hi,
On 07-07-17 00:39, Darren Hart wrote:
> On Sat, Jul 01, 2017 at 12:15:22PM +0200, Hans de Goede wrote:
>> Add touchscreen info for I.T.Works TW891 2-in-1.
>>
>
> ...
>
>> + /* I.T.Works TW891 */
>> + .driver_data = (void *)&itworks_tw891_data,
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
>
> *groan* you're trolling me now right? ;-)
Nope, sorry, this seemed better then matching on a single
string. FWIW I did an internet search for TW891 and there are
no other devices named TW891.
>> + DMI_MATCH(DMI_PRODUCT_NAME, "TW891"),
>
> I presume there are no other identifying strings?
Correct if there was something better I would have used it.
> Pushed to testing.
Thank you.
Regards,
Hans
prev parent reply other threads:[~2017-07-07 11:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-01 10:15 Hans de Goede
2017-07-06 22:39 ` Darren Hart
2017-07-07 11:03 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f04d821a-866f-0213-e9e8-b83da6b136a3@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®