From: Guenter Roeck <linux@roeck-us.net>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: Remove stale CONFIG_SENSORS_SBRMI Makefile reference
Date: Thu, 30 Apr 2026 11:19:16 -0700 [thread overview]
Message-ID: <f05a7ec3-8afa-484a-9385-87a0e18af9c8@roeck-us.net> (raw)
In-Reply-To: <20260426000319.55908-1-sashal@kernel.org>
On Sat, Apr 25, 2026 at 08:03:19PM -0400, Sasha Levin wrote:
> kconfiglint reports:
>
> X001: CONFIG_SENSORS_SBRMI referenced in Makefile but not defined
> in any Kconfig
>
> The SB-RMI hardware monitoring driver was originally introduced in
> commit 5a0f50d110b3 ("hwmon: Add support for SB-RMI power module") with
> both a Kconfig entry (CONFIG_SENSORS_SBRMI) and a Makefile line
> (obj-$(CONFIG_SENSORS_SBRMI) += sbrmi.o) in drivers/hwmon/.
>
> Commit e156586764050 ("hwmon/misc: amd-sbi: Move core sbrmi from hwmon to
> misc")
> moved the driver to drivers/misc/amd-sbi/ to support additional
> functionality beyond hardware monitoring. That commit correctly removed the
> Kconfig entry from drivers/hwmon/Kconfig, moved the source file
> drivers/hwmon/sbrmi.c to drivers/misc/amd-sbi/sbrmi.c, and created new
> Kconfig/Makefile entries in drivers/misc/amd-sbi/ with a renamed symbol
> (CONFIG_AMD_SBRMI_I2C).
>
> However, the Makefile line in drivers/hwmon/Makefile was not removed in
> that commit. The orphaned line references a CONFIG symbol that no longer
> exists and a source file that is no longer present, so it has no effect
> on the build — but it is dead code that should be cleaned up.
>
> Remove the stale Makefile reference.
>
> Assisted-by: Claude:claude-opus-4-6 kconfiglint
> Signed-off-by: Sasha Levin <sashal@kernel.org>
Applied.
Thanks,
Guenter
prev parent reply other threads:[~2026-04-30 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 0:03 Sasha Levin
2026-04-30 18:19 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f05a7ec3-8afa-484a-9385-87a0e18af9c8@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®