From: Vegard Nossum <vegard.nossum@oracle.com>
To: Dmitry Vyukov <dvyukov@google.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrey Konovalov <andreyknvl@google.com>,
Nicolai Stange <nicstange@gmail.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Kees Cook <keescook@chromium.org>,
James Morse <james.morse@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
Quentin Casasnovas <quentin.casasnovas@oracle.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] kcov: properly check if we are in an interrupt
Date: Tue, 27 Sep 2016 13:22:30 +0200 [thread overview]
Message-ID: <f05baa70-5a6f-c53f-89a6-a3279df6eb83@oracle.com> (raw)
In-Reply-To: <dd6202ff-3874-38dc-20e0-97d495dc40c7@oracle.com>
On 09/27/2016 01:20 PM, Vegard Nossum wrote:
> Your patch was:
>
> - if (!t || in_interrupt())
> + if (!t || (preempt_count() & (HARDIRQ_MASK | SOFTIRQ_OFFSET
> + | NMI_MASK)))
>
> But look at the definitions:
>
> #define irq_count() (preempt_count() & (HARDIRQ_MASK | SOFTIRQ_MASK \
> | NMI_MASK))
> #define in_interrupt() (irq_count())
>
> So isn't the patch a no-op to start with?
Eh, SOFTIRQ_OFFSET vs SOFTIRQ_MASK.
I'll just go stand in the corner.
Vegard
prev parent reply other threads:[~2016-09-27 11:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 14:51 Andrey Konovalov
2016-09-26 23:32 ` Andrew Morton
2016-09-27 6:21 ` Dmitry Vyukov
2016-09-27 7:34 ` Peter Zijlstra
2016-09-27 7:50 ` Dmitry Vyukov
2016-09-27 10:59 ` Peter Zijlstra
2016-09-27 12:32 ` Dmitry Vyukov
2016-09-27 11:20 ` Vegard Nossum
2016-09-27 11:22 ` Vegard Nossum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f05baa70-5a6f-c53f-89a6-a3279df6eb83@oracle.com \
--to=vegard.nossum@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=james.morse@arm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nicstange@gmail.com \
--cc=peterz@infradead.org \
--cc=quentin.casasnovas@oracle.com \
--cc=ryabinin.a.a@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®