Re: [PATCH net-next 1/2] nfc: s3fwrn5: fix order of freeing resources

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 29/09/2022 07:04, Dmitry Torokhov wrote:
> Caution needs to be exercised when mixing together regular and managed
> resources. In case of this driver devm_request_threaded_irq() should
> not be used, because it will result in the interrupt being freed too
> late, and there being a chance that it fires up at an inopportune
> moment and reference already freed data structures.

Non-devm was so far recommended only for IRQF_SHARED, not for regular
ones. Otherwise you have to fix half of Linux kernel drivers... why is
s3fwrn5 special?

Please use scripts/get_maintainers.pl to Cc also netdev folks.

> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/nfc/s3fwrn5/i2c.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
Best regards,
Krzysztof