mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, maz@kernel.org,
	will@kernel.org, catalin.marinas@arm.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, steven.price@arm.com,
	aneesh.kumar@kernel.org, oupton@kernel.org, gshan@redhat.com,
	joey.gouly@arm.com, tabba@google.com, yuzenghui@huawei.com,
	linux-coco@lists.linux.dev, gankulkarni@os.amperecomputing.com,
	sdonthineni@nvidia.com, alpergun@google.com,
	fj0570is@fujitsu.com, WeiLin.Chang@arm.com,
	lpieralisi@kernel.org, enju.kohei@fujitsu.com
Subject: Re: [PATCH v18 2/7] firmware: arm_rmm: Check for RMI support at init
Date: Mon, 21 Sep 2026 10:00:20 +0100	[thread overview]
Message-ID: <f0a4672d-c7f2-42d4-9fc7-b5a1d0ad3b83@arm.com> (raw)
In-Reply-To: <178978126541.2352296.3637463397103730192.b4-review@b4>

On 19/09/2026 02:27, Jonathan Cameron wrote:
>> Query the RMI version number and check if it is a compatible version.
>> The first two feature registers are read and exposed for future code to
>> use.
>>
>> We only support this for Little Endian kernels, the Big Endian kernel
>> support is anyway marked BROKEN and is being removed.
> 
> Can we have a small comment here on why the default is y
> 
> It's a big thing to opt into by default.  Feels like defconfig
> material maybe but not in the Kconfig defaults unless I'm missing
> something.

We need this for KVM arm64. I could drop the default here and
KVM selects this anyways. But, how far do we go on this ?
Do we need to be able to disable this completely even for KVM ?

As such it is a relatively smaller blob:

$ size drivers/firmware/arm_rmm/rmi.o
    text    data     bss     dec     hex filename
    7477     572       1    8050    1f72 drivers/firmware/arm_rmm/rmi.o

Cheers
Suzuki

> 
> 
>>
>> Signed-off-by: Steven Price <steven.price@arm.com>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> 
>> diff --git a/drivers/firmware/arm_rmm/Kconfig b/drivers/firmware/arm_rmm/Kconfig
>> new file mode 100644
>> index 000000000000..82724ee23186
>> --- /dev/null
>> +++ b/drivers/firmware/arm_rmm/Kconfig
>> @@ -0,0 +1,26 @@
>> +
>> +config ARCH_SUPPORTS_RMM
>> +	bool
>> +
>> +config ARM_RMM_RMI
>> +	bool "Realm Management Interface (RMI) Support"
>> +	depends on ARCH_SUPPORTS_RMM
>> +	default y
> Really? Why?

> 


  reply	other threads:[~2026-09-21  9:00 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-12  8:36 [PATCH v18 0/7] firmware: arm_rmm: Add RMM v2.0 base RMI support Suzuki K Poulose
2026-09-12  8:36 ` [PATCH v18 1/7] firmware: arm_rmm: Add SMC definitions for calling the RMM Suzuki K Poulose
2026-09-14  0:28   ` Gavin Shan
2026-09-19  1:27   ` Jonathan Cameron
2026-09-21  9:27     ` Suzuki K Poulose
2026-09-21 10:02       ` Suzuki K Poulose
2026-09-21 21:27         ` Jonathan Cameron
2026-09-21 10:14       ` Suzuki K Poulose
2026-09-21 21:29         ` Jonathan Cameron
2026-09-21 21:33       ` Jonathan Cameron
2026-09-12  8:36 ` [PATCH v18 2/7] firmware: arm_rmm: Check for RMI support at init Suzuki K Poulose
2026-09-14  1:04   ` Gavin Shan
2026-09-14 10:27   ` Sudeep Holla
2026-09-19  1:27   ` Jonathan Cameron
2026-09-21  9:00     ` Suzuki K Poulose [this message]
2026-09-21 21:37       ` Jonathan Cameron
2026-09-12  8:36 ` [PATCH v18 3/7] firmware: arm_rmm: Configure the RMM with the host's page size Suzuki K Poulose
2026-09-14  1:21   ` Gavin Shan
2026-09-14  6:34     ` Suzuki K Poulose
2026-09-19  1:27   ` Jonathan Cameron
2026-09-21  9:31     ` Suzuki K Poulose
2026-09-12  8:36 ` [PATCH v18 4/7] firmware: arm_rmm: Add support for SRO Suzuki K Poulose
2026-09-14  5:04   ` Gavin Shan
2026-09-14  6:22     ` Suzuki K Poulose
2026-09-14  8:19       ` Suzuki K Poulose
2026-09-14  9:59         ` Gavin Shan
2026-09-14  9:50       ` Gavin Shan
2026-09-14 12:50   ` Sudeep Holla
2026-09-14 14:02     ` Suzuki K Poulose
2026-09-14 14:47       ` Suzuki K Poulose
2026-09-19  1:27   ` Jonathan Cameron
2026-09-21 12:42     ` Suzuki K Poulose
2026-09-21 21:46       ` Jonathan Cameron
2026-09-12  8:36 ` [PATCH v18 5/7] firmware: arm_rmm: Activate the RMM Suzuki K Poulose
2026-09-14  5:06   ` Gavin Shan
2026-09-19  1:27   ` Jonathan Cameron
2026-09-21  9:04     ` Suzuki K Poulose
2026-09-12  8:36 ` [PATCH v18 6/7] firmware: arm_rmm: Ensure the RMM has GPT entries for memory Suzuki K Poulose
2026-09-14  5:41   ` Gavin Shan
2026-09-14  8:38     ` Suzuki K Poulose
2026-09-16 18:23   ` Alper Gun
2026-09-21  9:30     ` Suzuki K Poulose
2026-09-19  1:27   ` Jonathan Cameron
2026-09-21  9:32     ` Suzuki K Poulose
2026-09-21 13:38       ` Suzuki K Poulose
2026-09-21 21:58         ` Jonathan Cameron
2026-09-12  8:36 ` [PATCH v18 7/7] firmware: arm_rmm: Add wrappers for Realm related RMI commands Suzuki K Poulose
2026-09-14  5:46   ` Gavin Shan
2026-09-15 19:35   ` Alper Gun
2026-09-15 19:55     ` Suzuki K Poulose
2026-09-19  1:27   ` Jonathan Cameron
2026-09-21 21:53 ` [PATCH v18 0/7] firmware: arm_rmm: Add RMM v2.0 base RMI support Jonathan Cameron
2026-09-21 22:38   ` Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0a4672d-c7f2-42d4-9fc7-b5a1d0ad3b83@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=WeiLin.Chang@arm.com \
    --cc=alpergun@google.com \
    --cc=aneesh.kumar@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=enju.kohei@fujitsu.com \
    --cc=fj0570is@fujitsu.com \
    --cc=gankulkarni@os.amperecomputing.com \
    --cc=gshan@redhat.com \
    --cc=joey.gouly@arm.com \
    --cc=jonathan.cameron@oss.qualcomm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=maz@kernel.org \
    --cc=oupton@kernel.org \
    --cc=sdonthineni@nvidia.com \
    --cc=steven.price@arm.com \
    --cc=tabba@google.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®