mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] mm/mempolicy: remove unused mpol_is_preferred_many()
@ 2026-10-23 16:10 Sang-Heon Jeon
  2026-10-23 19:33 ` Gregory Price (Meta)
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Sang-Heon Jeon @ 2026-10-23 16:10 UTC (permalink / raw)
  To: Andrew Morton, David Hildenbrand, Gregory Price
  Cc: Joshua Hahn, linux-kernel, linux-mm, Rakie Kim, Ying Huang, Zi Yan

Since commit a492abe28bec ("mm: hugetlb: move mpol interpretation out of
dequeue_hugetlb_folio_vma()"), mpol_is_preferred_many() has no callers.

So remove it.

No functional change.

Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
 include/linux/mempolicy.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/include/linux/mempolicy.h b/include/linux/mempolicy.h
index 65c732d440d2..cd8f944209ca 100644
--- a/include/linux/mempolicy.h
+++ b/include/linux/mempolicy.h
@@ -173,11 +173,6 @@ int mpol_misplaced(struct folio *folio, struct vm_fault *vmf,
 					unsigned long addr);
 extern void mpol_put_task_policy(struct task_struct *);
 
-static inline bool mpol_is_preferred_many(struct mempolicy *pol)
-{
-	return  (pol->mode == MPOL_PREFERRED_MANY);
-}
-
 extern bool apply_policy_zone(struct mempolicy *policy, enum zone_type zone);
 
 extern int mempolicy_set_node_perf(unsigned int node,
@@ -298,10 +293,5 @@ static inline void mpol_put_task_policy(struct task_struct *task)
 {
 }
 
-static inline bool mpol_is_preferred_many(struct mempolicy *pol)
-{
-	return  false;
-}
-
 #endif /* CONFIG_NUMA */
 #endif

base-commit: fcec4f4bcc1101dbd7e3aff267856b3bbfe128c6
-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mm/mempolicy: remove unused mpol_is_preferred_many()
  2026-10-23 16:10 [PATCH] mm/mempolicy: remove unused mpol_is_preferred_many() Sang-Heon Jeon
@ 2026-10-23 19:33 ` Gregory Price (Meta)
  2026-10-23 20:23 ` Zi Yan
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Gregory Price (Meta) @ 2026-10-23 19:33 UTC (permalink / raw)
  To: Sang-Heon Jeon
  Cc: Andrew Morton, David Hildenbrand, Gregory Price, Joshua Hahn,
	linux-kernel, linux-mm, Rakie Kim, Ying Huang, Zi Yan

On 2026-10-24 01:10 +0900, Sang-Heon Jeon wrote:
> Since commit a492abe28bec ("mm: hugetlb: move mpol interpretation out of
> dequeue_hugetlb_folio_vma()"), mpol_is_preferred_many() has no callers.
> 
> So remove it.
> 
> No functional change.
> 
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>

looks good to me

Acked-by: Gregory Price (Meta) <gourry@gourry.net>

-- 
~Gregory


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mm/mempolicy: remove unused mpol_is_preferred_many()
  2026-10-23 16:10 [PATCH] mm/mempolicy: remove unused mpol_is_preferred_many() Sang-Heon Jeon
  2026-10-23 19:33 ` Gregory Price (Meta)
@ 2026-10-23 20:23 ` Zi Yan
  2026-10-23 20:56 ` David Hildenbrand (Arm)
  2026-10-24  0:32 ` SJ Park
  3 siblings, 0 replies; 5+ messages in thread
From: Zi Yan @ 2026-10-23 20:23 UTC (permalink / raw)
  To: Sang-Heon Jeon
  Cc: Andrew Morton, David Hildenbrand, Gregory Price, Joshua Hahn,
	linux-kernel, linux-mm, Rakie Kim, Ying Huang

On 23 Oct 2026, at 12:10, Sang-Heon Jeon wrote:

> Since commit a492abe28bec ("mm: hugetlb: move mpol interpretation out of
> dequeue_hugetlb_folio_vma()"), mpol_is_preferred_many() has no callers.
>
> So remove it.
>
> No functional change.
>
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> ---
>  include/linux/mempolicy.h | 10 ----------
>  1 file changed, 10 deletions(-)
>
LGTM.

Reviewed-by: Zi Yan <ziy@nvidia.com>

Best Regards,
Yan, Zi

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mm/mempolicy: remove unused mpol_is_preferred_many()
  2026-10-23 16:10 [PATCH] mm/mempolicy: remove unused mpol_is_preferred_many() Sang-Heon Jeon
  2026-10-23 19:33 ` Gregory Price (Meta)
  2026-10-23 20:23 ` Zi Yan
@ 2026-10-23 20:56 ` David Hildenbrand (Arm)
  2026-10-24  0:32 ` SJ Park
  3 siblings, 0 replies; 5+ messages in thread
From: David Hildenbrand (Arm) @ 2026-10-23 20:56 UTC (permalink / raw)
  To: Sang-Heon Jeon, Andrew Morton, Gregory Price
  Cc: Joshua Hahn, linux-kernel, linux-mm, Rakie Kim, Ying Huang, Zi Yan

On 10/23/26 18:10, Sang-Heon Jeon wrote:
> Since commit a492abe28bec ("mm: hugetlb: move mpol interpretation out of
> dequeue_hugetlb_folio_vma()"), mpol_is_preferred_many() has no callers.
> 
> So remove it.
> 
> No functional change.
> 
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> ---

I'll likely pick this up for the next cycle. After the merge window ;)

Acked-by: David Hildenbrand (Arm) <david@kernel.org>

-- 
Cheers,

David

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mm/mempolicy: remove unused mpol_is_preferred_many()
  2026-10-23 16:10 [PATCH] mm/mempolicy: remove unused mpol_is_preferred_many() Sang-Heon Jeon
                   ` (2 preceding siblings ...)
  2026-10-23 20:56 ` David Hildenbrand (Arm)
@ 2026-10-24  0:32 ` SJ Park
  3 siblings, 0 replies; 5+ messages in thread
From: SJ Park @ 2026-10-24  0:32 UTC (permalink / raw)
  To: Sang-Heon Jeon
  Cc: SJ Park, Andrew Morton, David Hildenbrand, Gregory Price,
	Joshua Hahn, linux-kernel, linux-mm, Rakie Kim, Ying Huang,
	Zi Yan

On Sat, 24 Oct 2026 01:10:01 +0900 Sang-Heon Jeon <ekffu200098@gmail.com> wrote:

> Since commit a492abe28bec ("mm: hugetlb: move mpol interpretation out of
> dequeue_hugetlb_folio_vma()"), mpol_is_preferred_many() has no callers.

Looks correct to me.

> 
> So remove it.
> 
> No functional change.
> 
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>

Reviewed-by: SJ Park <sj@kernel.org>


Thanks,
SJ

[...]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-10-24  0:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-23 16:10 [PATCH] mm/mempolicy: remove unused mpol_is_preferred_many() Sang-Heon Jeon
2026-10-23 19:33 ` Gregory Price (Meta)
2026-10-23 20:23 ` Zi Yan
2026-10-23 20:56 ` David Hildenbrand (Arm)
2026-10-24  0:32 ` SJ Park

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®