Re: [PATCH 4/4] media: qcom: camss: Report hardware version via media controller

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 7/17/26 4:20 PM, Loic Poulain wrote:
> Populate media_dev.hw_revision with the top-level CAMSS hardware version
> so that user space can query the exact hardware variant through the media
> controller (e.g. via media-ctl or MEDIA_IOC_DEVICE_INFO). This can help
> identify the platform variant and adapt behaviour accordingly, for example
> allowing libcamera to apply quirks or enable features that cannot be
> discovered through standard V4L2 or media-controller APIs.

[...]

> +static void camss_read_version(struct camss *camss)
> +{
> +	u32 hw_version;
> +
> +	if (!camss->top_base || !camss->res->pm_clks[0])
> +		return;
> +
> +	if (pm_runtime_resume_and_get(camss->dev))
> +		return;
> +
> +	hw_version = readl_relaxed(camss->top_base + CAMSS_HW_VERSION);
> +
> +	pm_runtime_put_sync(camss->dev);

I think non-sync is fine here

TOP+0x0 seems to hold on TITAN, MSM8916 and MSM8996

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad