From: Andrew Lunn <andrew@lunn.ch>
To: David Yang <mmyangfl@gmail.com>
Cc: netdev@vger.kernel.org, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Simon Horman <horms@kernel.org>,
Russell King <linux@armlinux.org.uk>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6 3/3] net: dsa: yt921x: Add support for Motorcomm YT921x
Date: Sun, 24 Aug 2025 17:22:11 +0200 [thread overview]
Message-ID: <f0dd9bb9-63bc-4ca4-bc4f-99b2e583f94d@lunn.ch> (raw)
In-Reply-To: <20250824005116.2434998-4-mmyangfl@gmail.com>
> +
> +/******** hardware definitions ********/
> +/******** driver definitions ********/
> +/******** smi ********/
Comments like this don't add any value. And sometimes you need to move
functions around because we don't allow forward references.
Andrew
next prev parent reply other threads:[~2025-08-24 15:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-24 0:51 [PATCH net-next v6 0/3] " David Yang
2025-08-24 0:51 ` [PATCH net-next v6 1/3] dt-bindings: net: dsa: yt921x: Add Motorcomm YT921x switch support David Yang
2025-08-24 9:20 ` Krzysztof Kozlowski
2025-08-24 9:25 ` Yangfl
2025-08-24 17:16 ` Krzysztof Kozlowski
2025-08-25 2:39 ` Yangfl
2025-08-25 7:37 ` Krzysztof Kozlowski
2025-08-24 0:51 ` [PATCH net-next v6 2/3] net: dsa: tag_yt921x: add support for Motorcomm YT921x tags David Yang
2025-08-25 22:15 ` Vladimir Oltean
2025-08-26 1:47 ` Yangfl
2025-08-26 2:18 ` Andrew Lunn
2025-08-26 2:44 ` Yangfl
2025-08-26 14:38 ` Vladimir Oltean
2025-08-24 0:51 ` [PATCH net-next v6 3/3] net: dsa: yt921x: Add support for Motorcomm YT921x David Yang
2025-08-24 8:42 ` Russell King (Oracle)
2025-08-24 9:31 ` Yangfl
2025-08-24 15:22 ` Andrew Lunn [this message]
2025-08-24 15:26 ` Andrew Lunn
2025-08-24 15:34 ` Andrew Lunn
2025-08-24 15:51 ` Andrew Lunn
2025-08-24 16:38 ` Yangfl
2025-08-24 18:14 ` Russell King (Oracle)
2025-08-24 19:16 ` Andrew Lunn
2025-08-25 14:14 ` Yangfl
2025-08-26 19:07 ` Vladimir Oltean
2025-08-24 19:14 ` Andrew Lunn
2025-08-24 16:40 ` kernel test robot
2025-08-25 21:23 ` Vladimir Oltean
2025-08-26 5:19 ` Yangfl
2025-08-26 12:15 ` Andrew Lunn
2025-08-26 13:51 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0dd9bb9-63bc-4ca4-bc4f-99b2e583f94d@lunn.ch \
--to=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®