From: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Harsh Kumar Bijlani <quic_hbijlani@quicinc.com>
Cc: Jeff Johnson <jjohnson@kernel.org>,
Ripan Deuri <quic_rdeuri@quicinc.com>,
Vasanthakumar Thiagarajan
<vasanthakumar.thiagarajan@oss.qualcomm.com>,
linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] wifi: ath12k: clean up on error in ath12k_dp_setup()
Date: Fri, 19 Dec 2025 13:42:15 +0800 [thread overview]
Message-ID: <f113b35e-b84f-40b6-89a7-284018e93853@oss.qualcomm.com> (raw)
In-Reply-To: <aUOw1J0TU4VgeXj6@stanley.mountain>
On 12/18/2025 3:44 PM, Dan Carpenter wrote:
> Destroy the rhash_tbl before returning the error code.
Would be better if the actual problem can be described first.
>
> Fixes: a88cf5f71adf ("wifi: ath12k: Add hash table for ath12k_dp_link_peer")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/net/wireless/ath/ath12k/dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/dp.c b/drivers/net/wireless/ath/ath12k/dp.c
> index 9f05eea6695a..ab54c8a84d3e 100644
> --- a/drivers/net/wireless/ath/ath12k/dp.c
> +++ b/drivers/net/wireless/ath/ath12k/dp.c
> @@ -1513,7 +1513,7 @@ static int ath12k_dp_setup(struct ath12k_base *ab)
> HAL_WBM_IDLE_LINK, srng, n_link_desc);
> if (ret) {
> ath12k_warn(ab, "failed to setup link desc: %d\n", ret);
> - return ret;
> + goto rhash_destroy;
> }
>
> ret = ath12k_dp_cc_init(ab);
However since this is trivial ...
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
next prev parent reply other threads:[~2025-12-19 5:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 7:44 Dan Carpenter
2025-12-19 5:24 ` Vasanthakumar Thiagarajan
2025-12-19 7:18 ` Dan Carpenter
2025-12-19 8:03 ` Dan Carpenter
2025-12-19 5:42 ` Baochen Qiang [this message]
2025-12-22 10:25 ` kernel test robot
2026-01-16 1:26 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f113b35e-b84f-40b6-89a7-284018e93853@oss.qualcomm.com \
--to=baochen.qiang@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=dan.carpenter@linaro.org \
--cc=jjohnson@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_hbijlani@quicinc.com \
--cc=quic_rdeuri@quicinc.com \
--cc=vasanthakumar.thiagarajan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®