* [PATCH v2] dmaengine: xilinx: xdma: Fix Judgment of the return value
@ 2023-07-05 11:39 Minjie Du
2023-07-07 4:57 ` Michal Simek
2023-07-11 16:43 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Minjie Du @ 2023-07-05 11:39 UTC (permalink / raw)
To: michal.simek, Lizhi Hou, Brian Xu, Raj Kumar Rampelli,
Vinod Koul, open list:XILINX XDMA DRIVER,
moderated list:ARM/ZYNQ ARCHITECTURE, open list
Cc: opensource.kernel, Minjie Du
Fix: make IS_ERR() judge the devm_ioremap_resource() function return.
Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver")
Signed-off-by: Minjie Du <duminjie@vivo.com>
---
drivers/dma/xilinx/xdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
index 93ee298d5..ad5ff6335 100644
--- a/drivers/dma/xilinx/xdma.c
+++ b/drivers/dma/xilinx/xdma.c
@@ -892,7 +892,7 @@ static int xdma_probe(struct platform_device *pdev)
}
reg_base = devm_ioremap_resource(&pdev->dev, res);
- if (!reg_base) {
+ if (IS_ERR(reg_base)) {
xdma_err(xdev, "ioremap failed");
goto failed;
}
--
2.39.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dmaengine: xilinx: xdma: Fix Judgment of the return value
2023-07-05 11:39 [PATCH v2] dmaengine: xilinx: xdma: Fix Judgment of the return value Minjie Du
@ 2023-07-07 4:57 ` Michal Simek
2023-07-11 16:43 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2023-07-07 4:57 UTC (permalink / raw)
To: Minjie Du, Lizhi Hou, Brian Xu, Raj Kumar Rampelli, Vinod Koul,
open list:XILINX XDMA DRIVER,
moderated list:ARM/ZYNQ ARCHITECTURE, open list
Cc: opensource.kernel
On 7/5/23 13:39, Minjie Du wrote:
> Fix: make IS_ERR() judge the devm_ioremap_resource() function return.
>
> Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver")
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> drivers/dma/xilinx/xdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
> index 93ee298d5..ad5ff6335 100644
> --- a/drivers/dma/xilinx/xdma.c
> +++ b/drivers/dma/xilinx/xdma.c
> @@ -892,7 +892,7 @@ static int xdma_probe(struct platform_device *pdev)
> }
>
> reg_base = devm_ioremap_resource(&pdev->dev, res);
> - if (!reg_base) {
> + if (IS_ERR(reg_base)) {
> xdma_err(xdev, "ioremap failed");
> goto failed;
> }
Acked-by: Michal Simek <michal.simek@amd.com>
M
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dmaengine: xilinx: xdma: Fix Judgment of the return value
2023-07-05 11:39 [PATCH v2] dmaengine: xilinx: xdma: Fix Judgment of the return value Minjie Du
2023-07-07 4:57 ` Michal Simek
@ 2023-07-11 16:43 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-07-11 16:43 UTC (permalink / raw)
To: michal.simek, Lizhi Hou, Brian Xu, Raj Kumar Rampelli, dmaengine,
linux-arm-kernel, linux-kernel, Minjie Du
Cc: opensource.kernel
On Wed, 05 Jul 2023 19:39:12 +0800, Minjie Du wrote:
> Fix: make IS_ERR() judge the devm_ioremap_resource() function return.
>
>
Applied, thanks!
[1/1] dmaengine: xilinx: xdma: Fix Judgment of the return value
commit: 625758896cc84ce0e5dc9842c34d4b9fa23b8b36
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-11 16:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-05 11:39 [PATCH v2] dmaengine: xilinx: xdma: Fix Judgment of the return value Minjie Du
2023-07-07 4:57 ` Michal Simek
2023-07-11 16:43 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®