From: Markus Elfring <Markus.Elfring@web.de>
To: Muhammad Ahmed <muhammad.ahmed.27@hotmail.com>,
linux-xfs@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Carlos Maiolino <cem@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [PATCH] xfs: scrub: remove unnecessary braces and fix …
Date: Sat, 19 Jul 2025 10:33:19 +0200 [thread overview]
Message-ID: <f12a445e-536b-44e4-9291-a10dd16f227f@web.de> (raw)
In-Reply-To: <DB6PR07MB3142A5C5EAF928BA7F71CA47BB53A@DB6PR07MB3142.eurprd07.prod.outlook.com>
> This patch removes unnecessary braces around simple if-else blocks and
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc6#n94
How do you think about to use the following code variant?
xrep_findparent_scan_found(pscan, p->delta > 0 ? p->dp->i_ino : NULLFSINO);
> fixes inconsistent indentation in fs/xfs/scrub/findparent.c to comply
> with kernel coding style guidelines.
Please split possible changes into separate update steps.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc6#n81
Regards,
Markus
prev parent reply other threads:[~2025-07-19 8:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-19 5:22 [PATCH] xfs: scrub: remove unnecessary braces and fix or10n-cli
2025-07-19 5:29 ` Darrick J. Wong
2025-07-19 6:05 ` Carlos Maiolino
2025-07-19 8:33 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f12a445e-536b-44e4-9291-a10dd16f227f@web.de \
--to=markus.elfring@web.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=muhammad.ahmed.27@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®