[PATCH] xfs: scrub: remove unnecessary braces and fix

[PATCH] xfs: scrub: remove unnecessary braces and fix

[or10n-cli]

 From b8e455b79c84b4e1501ea554327672b6d391d35d Mon Sep 17 00:00:00 2001
From: or10n-cli <muhammad.ahmed.27@hotmail.com>
Date: Sat, 19 Jul 2025 10:10:42 +0500
Subject: [PATCH] xfs: scrub: remove unnecessary braces and fix 
indentation in
  findparent.c

This patch removes unnecessary braces around simple if-else blocks and
fixes inconsistent indentation in fs/xfs/scrub/findparent.c to comply
with kernel coding style guidelines.

All changes are verified using checkpatch.pl with no warnings or errors.

Signed-off-by: Muhammad Ahmed <muhammad.ahmed.27@hotmail.com>
---
  fs/xfs/scrub/findparent.c | 9 +++------
  1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/fs/xfs/scrub/findparent.c b/fs/xfs/scrub/findparent.c
index 84487072b6dd..9a2f25c7c2e3 100644
--- a/fs/xfs/scrub/findparent.c
+++ b/fs/xfs/scrub/findparent.c
@@ -229,15 +229,12 @@ xrep_findparent_live_update(
          */
         if (p->ip->i_ino == sc->ip->i_ino &&
             xchk_iscan_want_live_update(&pscan->iscan, p->dp->i_ino)) {
-               if (p->delta > 0) {
+               if (p->delta > 0)
                         xrep_findparent_scan_found(pscan, p->dp->i_ino);
-               } else {
+               else
                         xrep_findparent_scan_found(pscan, NULLFSINO);
-               }
         }
-
         return NOTIFY_DONE;
-}

  /*
   * Set up a scan to find the parent of a directory.  The provided 
dirent hook
@@ -386,7 +383,7 @@ xrep_findparent_confirm(

         /* Reject garbage parent inode numbers and self-referential 
parents. */
         if (*parent_ino == NULLFSINO)
-              return 0;
+               return 0;
         if (!xfs_verify_dir_ino(sc->mp, *parent_ino) ||
             *parent_ino == sc->ip->i_ino) {
                 *parent_ino = NULLFSINO;
--
2.47.2

Re: [PATCH] xfs: scrub: remove unnecessary braces and fix

[Darrick J. Wong]

On Sat, Jul 19, 2025 at 10:22:09AM +0500, or10n-cli wrote:
> From b8e455b79c84b4e1501ea554327672b6d391d35d Mon Sep 17 00:00:00 2001
> From: or10n-cli <muhammad.ahmed.27@hotmail.com>

WTF is "orion-cli" ?

> Date: Sat, 19 Jul 2025 10:10:42 +0500
> Subject: [PATCH] xfs: scrub: remove unnecessary braces and fix indentation
> in
>  findparent.c
> 
> This patch removes unnecessary braces around simple if-else blocks and
> fixes inconsistent indentation in fs/xfs/scrub/findparent.c to comply
> with kernel coding style guidelines.
> 
> All changes are verified using checkpatch.pl with no warnings or errors.
> 
> Signed-off-by: Muhammad Ahmed <muhammad.ahmed.27@hotmail.com>
> ---
>  fs/xfs/scrub/findparent.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/xfs/scrub/findparent.c b/fs/xfs/scrub/findparent.c
> index 84487072b6dd..9a2f25c7c2e3 100644
> --- a/fs/xfs/scrub/findparent.c
> +++ b/fs/xfs/scrub/findparent.c
> @@ -229,15 +229,12 @@ xrep_findparent_live_update(
>          */
>         if (p->ip->i_ino == sc->ip->i_ino &&
>             xchk_iscan_want_live_update(&pscan->iscan, p->dp->i_ino)) {
> -               if (p->delta > 0) {
> +               if (p->delta > 0)
>                         xrep_findparent_scan_found(pscan, p->dp->i_ino);
> -               } else {
> +               else
>                         xrep_findparent_scan_found(pscan, NULLFSINO);
> -               }
>         }
> -
>         return NOTIFY_DONE;
> -}

DID YOU EVEN COMPILE THIS???

--D

>  /*
>   * Set up a scan to find the parent of a directory.  The provided dirent
> hook
> @@ -386,7 +383,7 @@ xrep_findparent_confirm(
> 
>         /* Reject garbage parent inode numbers and self-referential parents.
> */
>         if (*parent_ino == NULLFSINO)
> -              return 0;
> +               return 0;
>         if (!xfs_verify_dir_ino(sc->mp, *parent_ino) ||
>             *parent_ino == sc->ip->i_ino) {
>                 *parent_ino = NULLFSINO;
> --
> 2.47.2
> 

Re: [PATCH] xfs: scrub: remove unnecessary braces and fix

[Carlos Maiolino]

On Fri, Jul 18, 2025 at 10:29:16PM -0700, Darrick J. Wong wrote:
> On Sat, Jul 19, 2025 at 10:22:09AM +0500, or10n-cli wrote:
> > From b8e455b79c84b4e1501ea554327672b6d391d35d Mon Sep 17 00:00:00 2001
> > From: or10n-cli <muhammad.ahmed.27@hotmail.com>
> 
> WTF is "orion-cli" ?

No clue, but those 'patches' are going to my spam-list from now on...

> 
> > Date: Sat, 19 Jul 2025 10:10:42 +0500
> > Subject: [PATCH] xfs: scrub: remove unnecessary braces and fix indentation
> > in
> >  findparent.c
> >
> > This patch removes unnecessary braces around simple if-else blocks and
> > fixes inconsistent indentation in fs/xfs/scrub/findparent.c to comply
> > with kernel coding style guidelines.
> >
> > All changes are verified using checkpatch.pl with no warnings or errors.
> >
> > Signed-off-by: Muhammad Ahmed <muhammad.ahmed.27@hotmail.com>
> > ---
> >  fs/xfs/scrub/findparent.c | 9 +++------
> >  1 file changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/fs/xfs/scrub/findparent.c b/fs/xfs/scrub/findparent.c
> > index 84487072b6dd..9a2f25c7c2e3 100644
> > --- a/fs/xfs/scrub/findparent.c
> > +++ b/fs/xfs/scrub/findparent.c
> > @@ -229,15 +229,12 @@ xrep_findparent_live_update(
> >          */
> >         if (p->ip->i_ino == sc->ip->i_ino &&
> >             xchk_iscan_want_live_update(&pscan->iscan, p->dp->i_ino)) {
> > -               if (p->delta > 0) {
> > +               if (p->delta > 0)
> >                         xrep_findparent_scan_found(pscan, p->dp->i_ino);
> > -               } else {
> > +               else
> >                         xrep_findparent_scan_found(pscan, NULLFSINO);
> > -               }
> >         }
> > -
> >         return NOTIFY_DONE;
> > -}
> 
> DID YOU EVEN COMPILE THIS???

I'll stop wasting time on patches from this sender.

And just for the *fun* of it... checkpatch.pl fails on this patch...


> 
> --D
> 
> >  /*
> >   * Set up a scan to find the parent of a directory.  The provided dirent
> > hook
> > @@ -386,7 +383,7 @@ xrep_findparent_confirm(
> >
> >         /* Reject garbage parent inode numbers and self-referential parents.
> > */
> >         if (*parent_ino == NULLFSINO)
> > -              return 0;
> > +               return 0;
> >         if (!xfs_verify_dir_ino(sc->mp, *parent_ino) ||
> >             *parent_ino == sc->ip->i_ino) {
> >                 *parent_ino = NULLFSINO;
> > --
> > 2.47.2
> >
> 

Re: [PATCH] xfs: scrub: remove unnecessary braces and fix …

[Markus Elfring]

> This patch removes unnecessary braces around simple if-else blocks and

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc6#n94


How do you think about to use the following code variant?

		xrep_findparent_scan_found(pscan, p->delta > 0 ? p->dp->i_ino : NULLFSINO);


> fixes inconsistent indentation in fs/xfs/scrub/findparent.c to comply
> with kernel coding style guidelines.

Please split possible changes into separate update steps.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc6#n81

Regards,
Markus