[PATCH] platform/x86: uniwill-laptop: Implement .hw_offloaded trigger callback

[PATCH] platform/x86: uniwill-laptop: Implement .hw_offloaded trigger callback

[Armin Wolf]

Since commit 8e04e5382aa9 ("leds: trigger: Add hw_offloaded() callback
and provide trigger_may_offload_to_hw attribute") the LED subsystem
allows triggers to report if they are being offloaded to the underlying
hardware. Implement the necessary callback so that the LED subsystem
knows that the lightbar trigger is always offloaded to hardware.

Fixes: d1c0c8996977 ("platform/x86: uniwill-laptop: Implement rainbow animation as trigger")
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
 drivers/platform/x86/uniwill/uniwill-acpi.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/platform/x86/uniwill/uniwill-acpi.c b/drivers/platform/x86/uniwill/uniwill-acpi.c
index f62d59f29676..ee444577e691 100644
--- a/drivers/platform/x86/uniwill/uniwill-acpi.c
+++ b/drivers/platform/x86/uniwill/uniwill-acpi.c
@@ -1543,12 +1543,18 @@ static void uniwill_lightbar_trigger_deactivate(struct led_classdev *led_cdev)
 		dev_err(led_cdev->dev, "Failed to stop rainbow animation: %d\n", ret);
 }
 
+static bool uniwill_lightbar_trigger_hw_offloaded(struct led_classdev *led_cdev)
+{
+	return true;
+}
+
 static struct led_hw_trigger_type uniwill_lightbar_trigger_type;
 
 static struct led_trigger uniwill_lightbar_trigger = {
 	.name = "uniwill-rainbow",
 	.activate = uniwill_lightbar_trigger_activate,
 	.deactivate = uniwill_lightbar_trigger_deactivate,
+	.hw_offloaded = uniwill_lightbar_trigger_hw_offloaded,
 	.trigger_type = &uniwill_lightbar_trigger_type,
 };
 
-- 
2.56.0

Re: [PATCH] platform/x86: uniwill-laptop: Implement .hw_offloaded trigger callback

[Ilpo Järvinen]

On Fri, 30 Oct 2026 20:46:44 +0100, Armin Wolf wrote:

> Since commit 8e04e5382aa9 ("leds: trigger: Add hw_offloaded() callback
> and provide trigger_may_offload_to_hw attribute") the LED subsystem
> allows triggers to report if they are being offloaded to the underlying
> hardware. Implement the necessary callback so that the LED subsystem
> knows that the lightbar trigger is always offloaded to hardware.
> 
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: uniwill-laptop: Implement .hw_offloaded trigger callback
      commit: 086aeca907789bd2604f16f07bfc073b19015015

--
 i.

Re: [PATCH] platform/x86: uniwill-laptop: Implement .hw_offloaded trigger callback

[Armin Wolf]

Am 02.11.26 um 12:48 schrieb Ilpo Järvinen:
> On Fri, 30 Oct 2026 20:46:44 +0100, Armin Wolf wrote:
> 
>> Since commit 8e04e5382aa9 ("leds: trigger: Add hw_offloaded() callback
>> and provide trigger_may_offload_to_hw attribute") the LED subsystem
>> allows triggers to report if they are being offloaded to the underlying
>> hardware. Implement the necessary callback so that the LED subsystem
>> knows that the lightbar trigger is always offloaded to hardware.
>>
>>
>> [...]
> 
> 
> Thank you for your contribution, it has been applied to my local
> review-ilpo-fixes branch. Note it will show up in the public
> platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
> local branch there, which might take a while.
> 
> The list of commits applied:
> [1/1] platform/x86: uniwill-laptop: Implement .hw_offloaded trigger callback
>        commit: 086aeca907789bd2604f16f07bfc073b19015015
> 
> --
>   i.
> 

Thank you :)

Armin Wolf