From: "Goel, Akash" <akash.goel@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
Tom Zanussi <tzanussi@gmail.com>,
akash.goel@intel.com
Subject: Re: [PATCH v2] relay: Add global mode support for buffer-only channels
Date: Tue, 12 Jul 2016 18:54:49 +0530 [thread overview]
Message-ID: <f150af9e-8f01-d703-3c8c-56aed88737b5@intel.com> (raw)
In-Reply-To: <20160712130100.GT6157@nuc-i3427.alporthouse.com>
On 7/12/2016 6:31 PM, Chris Wilson wrote:
> On Tue, Jul 12, 2016 at 06:20:06PM +0530, Goel, Akash wrote:
>> Thanks much, will update the documentation as well as the changelog
>> as per the above.
>>
>> But an export of symbol relay_late_setup_files() is still needed, just
>> like relay_open() is exported, in order to make it accessible to
>> modules like i915 ?
>
> Yes, we need the companion function in i915.ko. That needs to be
> explained in the patch notes to justify adding the EXPORT_SYMBOL.
> Otherwise without that context, it looks unnecessary as Andrew objected
> to.
Won't your suggested updates to Documentation & changelog suffice ?.
relay_late_setup_files() is to be used in conjunction with
relay_open(), hence need to be exported.
Do I also need to provide the corresponding i915 patch, which has a
call to relay_late_setup_files() ?
Best regards
Akash
> -Chris
>
next prev parent reply other threads:[~2016-07-12 13:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-03 16:15 [PATCH] " akash.goel
2016-07-04 8:00 ` Chris Wilson
2016-07-04 13:03 ` Goel, Akash
2016-07-11 7:17 ` [PATCH v2] " akash.goel
2016-07-11 20:17 ` Andrew Morton
2016-07-12 9:24 ` Chris Wilson
2016-07-12 12:50 ` Goel, Akash
2016-07-12 13:01 ` Chris Wilson
2016-07-12 13:24 ` Goel, Akash [this message]
2016-07-12 19:51 ` Andrew Morton
2016-07-13 7:39 ` [PATCH v3] " akash.goel
2016-07-13 8:30 ` kbuild test robot
2016-07-13 10:09 ` [PATCH v4] " akash.goel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f150af9e-8f01-d703-3c8c-56aed88737b5@intel.com \
--to=akash.goel@intel.com \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=eduard.munteanu@linux360.ro \
--cc=linux-kernel@vger.kernel.org \
--cc=tzanussi@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®