[PATCH 00/16] arm64: dts: exynos: Format with dtfmt

[PATCH 00/16] arm64: dts: exynos: Format with dtfmt

[Waqar Hameed]

I was looking through the notes for the last Devicetree microconference
at Linux Plumbers (LPC) 2025 [1], and realized that the tool I have been
working on might be of interest here: dtfmt - a Devicetree Source
formatter [2].

dtfmt uses a parser with lexical grammar (tree-sitter) directly ported
from the actual Device Tree Compiler's (dtc) lexer/parser, also
(hand)written by me [3]. It is primarily designed for the Linux kernel
and currently parses all 6872 devicetree files in the tree successfully
(found with `find . -iregex ".+\.dts[io]?$"`).

This tool was developed out of frustration when reviewing devicetree
patches internally at my company Axis. I would have published it earlier
if I was aware of the on-going discussions at LPC 2025. It only caught
my attention since I'm planning to attend LPC this year (especially the
Devicetree microconference and would therefore love to discuss this more
in-person!).

This patch series is only a small demonstration of dtfmt. Obviously one
can run dtfmt for all files and generate a much bigger diff, but I just
chose `arch/arm64/boot/dts/exynos/` here. Primarily to get Krzysztof in
the "To:"-field :)

Please note that since we don't currently have a _definitive_ style
guide for Devictree Source files, dtfmt tries to be pragmatic and try to
"guess" the intended style (e.g. alignment of arrays and comma separated
property data). Some things have been left out (for now), because it's
too hard to implement without any concrete style decisions in place
(e.g. alignment of comments, long line wrapping etc.). dtfmt will
continue to develop and will always align with the Linux kernel.
Feedback (and collaboration) is therefore greatly appreciated!

[1] https://lpc.events/event/19/sessions/237/attachments/1713/4459/Notes%20-%20Devicetree%20MC%20-%20LPC%202025.pdf
[1] https://codeberg.org/whame/dtfmt
    Mirror: https://github.com/whame/dtfmt
[2] https://codeberg.org/whame/tree-sitter-devicetree
    Mirror: https://github.com/whame/tree-sitter-devicetree

Waqar Hameed (16):
  arm64: dts: exynos2200: Remove empty line at end of node
  arm64: dts: exynos5433: Use tabs for indentation
  arm64: dts: exynos7: Remove empty line at end of node
  arm64: dts: exynos7: Align comments with minimal whitespace
  arm64: dts: exynos7885: Fix format of line comment
  arm64: dts: exynos7885: Align end of node definition brace
  arm64: dts: exynos850: Align end of node definition brace
  arm64: dts: exynos850: Use tabs for indentation
  arm64: dts: exynos8850: Add missing space in compatible
  arm64: dts: exynos8855: Remove empty line at end of node
  arm64: dts: exynos8855: Use tabs for indentation
  arm64: dts: exynosautov920: Add space before line comments
  arm64: dts: exynosautov920: Add missing space in compatible
  arm64: dts: exynosautov920: Remove empty line at end of node
  arm64: dts: exynos: gs101: Use tabs for indentation
  arm64: dts: exynos: gs101: Add space before line comments

 arch/arm64/boot/dts/exynos/exynos2200-pinctrl.dtsi   |  2 --
 arch/arm64/boot/dts/exynos/exynos2200.dtsi           |  1 -
 .../arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi |  4 ++--
 arch/arm64/boot/dts/exynos/exynos7-espresso.dts      |  1 -
 arch/arm64/boot/dts/exynos/exynos7.dtsi              |  8 ++++----
 arch/arm64/boot/dts/exynos/exynos7885-pinctrl.dtsi   |  4 ++--
 arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi    |  2 +-
 arch/arm64/boot/dts/exynos/exynos850.dtsi            |  8 ++++----
 arch/arm64/boot/dts/exynos/exynos8855-smdk.dts       |  3 +--
 arch/arm64/boot/dts/exynos/exynos8855.dtsi           |  8 ++++----
 arch/arm64/boot/dts/exynos/exynos8895-pinctrl.dtsi   | 10 +++++-----
 arch/arm64/boot/dts/exynos/exynosautov920.dtsi       |  9 ++++-----
 arch/arm64/boot/dts/exynos/google/gs101.dtsi         | 12 ++++++------
 13 files changed, 33 insertions(+), 39 deletions(-)


base-commit: 72d3fcf802c45d00b300f25b848a93c3a2bd7c7e
-- 
2.43.0

[PATCH 01/16] arm64: dts: exynos2200: Remove empty line at end of node

[Waqar Hameed]

There shouldn't be an empty line at end of node definition. Found/fixed
with dtfmt (Devicetree Source formatter).

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
 arch/arm64/boot/dts/exynos/exynos2200-pinctrl.dtsi | 2 --
 arch/arm64/boot/dts/exynos/exynos2200.dtsi         | 1 -
 2 files changed, 3 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos2200-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos2200-pinctrl.dtsi
index 5877da7baf5c4..d5aede3af15f7 100644
--- a/arch/arm64/boot/dts/exynos/exynos2200-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos2200-pinctrl.dtsi
@@ -702,7 +702,6 @@ uart20_bus_dual: uart20-bus-dual-pins {
 		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
 		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
 	};
-
 };
 
 &pinctrl_hsi1 {
@@ -1171,7 +1170,6 @@ uart12_bus_dual: uart12-bus-dual-pins {
 		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
 		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
 	};
-
 };
 
 &pinctrl_peric2 {
diff --git a/arch/arm64/boot/dts/exynos/exynos2200.dtsi b/arch/arm64/boot/dts/exynos/exynos2200.dtsi
index b1c134f223245..3b853d66e19ce 100644
--- a/arch/arm64/boot/dts/exynos/exynos2200.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos2200.dtsi
@@ -712,7 +712,6 @@ hsi2c_21: i2c@10970000 {
 
 				status = "disabled";
 			};
-
 		};
 
 		cmu_hsi0: clock-controller@10a00000 {
-- 
2.43.0

[PATCH 02/16] arm64: dts: exynos5433: Use tabs for indentation

[Waqar Hameed]

Tabs should be used instead of whitespace for indentation. Found/fixed
with dtfmt (Devicetree Source formatter).

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
 arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index 0ad02a098765d..4f3124069849d 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -1064,8 +1064,8 @@ &ppmu_d1_general {
 
 	events {
 		ppmu_event0_d1_general: ppmu-event0-d1-general {
-		       event-name = "ppmu-event0-d1-general";
-	       };
+			event-name = "ppmu-event0-d1-general";
+		};
 	};
 };
 
-- 
2.43.0

[PATCH 03/16] arm64: dts: exynos7: Remove empty line at end of node

[Waqar Hameed]

There shouldn't be an empty line at end of node definition. Found/fixed
with dtfmt (Devicetree Source formatter).

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
 arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
index b3d5b447aeb68..bbc5df5a1dace 100644
--- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
@@ -52,7 +52,6 @@ usb3drd_boost_5v: regulator-usb3drd-boost {
 		pinctrl-0 = <&usb3drd_boost_en>;
 		enable-active-high;
 	};
-
 };
 
 &fin_pll {
-- 
2.43.0

[PATCH 04/16] arm64: dts: exynos7: Align comments with minimal whitespace

[Waqar Hameed]

There is no need to have superfluous whitespace to align comments. Use
minimal amount to achieve the same thing. Found/fixed with
dtfmt (Devicetree Source formatter).

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
 arch/arm64/boot/dts/exynos/exynos7.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
index 20e24db952fa6..865add183ea2b 100644
--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
@@ -669,10 +669,10 @@ tmuctrl_0: tmu@10060000 {
 
 		ufs: ufs@15570000 {
 			compatible = "samsung,exynos7-ufs";
-			reg = <0x15570000 0x100>,  /* 0: HCI standard */
-			      <0x15570100 0x100>,  /* 1: Vendor specified */
-			      <0x15571000 0x200>,  /* 2: UNIPRO */
-			      <0x15572000 0x300>;  /* 3: UFS protector */
+			reg = <0x15570000 0x100>, /* 0: HCI standard */
+			      <0x15570100 0x100>, /* 1: Vendor specified */
+			      <0x15571000 0x200>, /* 2: UNIPRO */
+			      <0x15572000 0x300>; /* 3: UFS protector */
 			reg-names = "hci", "vs_hci", "unipro", "ufsp";
 			interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clock_fsys1 ACLK_UFS20_LINK>,
-- 
2.43.0

[PATCH 05/16] arm64: dts: exynos7885: Fix format of line comment

[Waqar Hameed]

There should be a space before ending comment delimiter. Found/fixed
with dtfmt (Devicetree Source formatter).

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
 arch/arm64/boot/dts/exynos/exynos7885-pinctrl.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos7885-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos7885-pinctrl.dtsi
index 34bb121919556..f4c89cbbafe70 100644
--- a/arch/arm64/boot/dts/exynos/exynos7885-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7885-pinctrl.dtsi
@@ -638,7 +638,7 @@ uart4_bus_single: uart4-bus-single-pins {
 		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
 	};
 
-	/* USI1 UART_HSI2C1*/
+	/* USI1 UART_HSI2C1 */
 	uart4_bus_dual: uart4-bus-dual-pins {
 		samsung,pins = "gpc2-5", "gpc2-4";
 		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
-- 
2.43.0

[PATCH 06/16] arm64: dts: exynos7885: Align end of node definition brace

[Waqar Hameed]

End of node definition should be indented with a tab only. Found/fixed
with dtfmt (Devicetree Source formatter).

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
 arch/arm64/boot/dts/exynos/exynos7885-pinctrl.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos7885-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos7885-pinctrl.dtsi
index f4c89cbbafe70..76fb239e4322b 100644
--- a/arch/arm64/boot/dts/exynos/exynos7885-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7885-pinctrl.dtsi
@@ -809,7 +809,7 @@ uart5_bus_single: uart5-bus-single-pins {
 		samsung,pins = "gpp8-1", "gpp8-0", "gpp7-1", "gpp7-0";
 		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
 		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
-	  };
+	};
 
 	/* USI2 UART_HSI2C1 */
 	uart5_bus_dual: uart5-bus-dual-pins {
-- 
2.43.0

[PATCH 07/16] arm64: dts: exynos850: Align end of node definition brace

[Waqar Hameed]

End of node definition should be indented with a tab only. Found/fixed
with dtfmt (Devicetree Source formatter).

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
 arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi
index e3f1ae8dedbff..523df53ee980a 100644
--- a/arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi
@@ -362,7 +362,7 @@ sd2_cmd_pins: sd2-cmd-pins {
 		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
 		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
 		samsung,pin-drv = <EXYNOS850_HSI_PIN_DRV_LV2>;
-	 };
+	};
 
 	sd2_bus1_pins: sd2-bus1-pins {
 		samsung,pins = "gpf2-2";
-- 
2.43.0

[PATCH 08/16] arm64: dts: exynos850: Use tabs for indentation

[Waqar Hameed]

Tabs should be used instead of whitespace for indentation. Found/fixed
with dtfmt (Devicetree Source formatter).

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
 arch/arm64/boot/dts/exynos/exynos850.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi
index 911643008b9f5..89069c19329c0 100644
--- a/arch/arm64/boot/dts/exynos/exynos850.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi
@@ -164,10 +164,10 @@ timer {
 		compatible = "arm,armv8-timer";
 		/* Hypervisor Virtual Timer interrupt is not wired to GIC */
 		interrupts =
-		     <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
-		     <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
-		     <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
-		     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>;
+			<GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
+			<GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
+			<GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
+			<GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>;
 	};
 
 	soc: soc@0 {
-- 
2.43.0

[PATCH 09/16] arm64: dts: exynos8850: Add missing space in compatible

[Waqar Hameed]

Tabs should be a space between multiple property data. Found/fixed with
dtfmt (Devicetree Source formatter).

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
 arch/arm64/boot/dts/exynos/exynos8855-smdk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos8855-smdk.dts b/arch/arm64/boot/dts/exynos/exynos8855-smdk.dts
index e74ff8a1bbcf6..ec6db81536a4e 100644
--- a/arch/arm64/boot/dts/exynos/exynos8855-smdk.dts
+++ b/arch/arm64/boot/dts/exynos/exynos8855-smdk.dts
@@ -14,7 +14,7 @@
 
 / {
 	model = "Samsung Exynos8855 SMDK board";
-	compatible = "samsung,exynos8855-smdk","samsung,exynos8855";
+	compatible = "samsung,exynos8855-smdk", "samsung,exynos8855";
 
 	chosen {
 	};
-- 
2.43.0

[PATCH 10/16] arm64: dts: exynos8855: Remove empty line at end of node

[Waqar Hameed]

There shouldn't be an empty line at end of node definition. Found/fixed
with dtfmt (Devicetree Source formatter).

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
 arch/arm64/boot/dts/exynos/exynos8855-smdk.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos8855-smdk.dts b/arch/arm64/boot/dts/exynos/exynos8855-smdk.dts
index ec6db81536a4e..2dade82fe126c 100644
--- a/arch/arm64/boot/dts/exynos/exynos8855-smdk.dts
+++ b/arch/arm64/boot/dts/exynos/exynos8855-smdk.dts
@@ -23,7 +23,6 @@ memory@80000000 {
 		device_type = "memory";
 		reg = <0x0 0x80000000 0x80000000>;
 	};
-
 };
 
 &oscclk {
-- 
2.43.0

[PATCH 11/16] arm64: dts: exynos8855: Use tabs for indentation

[Waqar Hameed]

Tabs should be used instead of whitespace for indentation. Found/fixed
with dtfmt (Devicetree Source formatter).

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
 arch/arm64/boot/dts/exynos/exynos8855.dtsi         |  8 ++++----
 arch/arm64/boot/dts/exynos/exynos8895-pinctrl.dtsi | 10 +++++-----
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos8855.dtsi b/arch/arm64/boot/dts/exynos/exynos8855.dtsi
index 0333b80eba845..e43d26d716552 100644
--- a/arch/arm64/boot/dts/exynos/exynos8855.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos8855.dtsi
@@ -199,10 +199,10 @@ timer {
 		compatible = "arm,armv8-timer";
 		/* Hypervisor Virtual Timer interrupt is not wired to GIC */
 		interrupts =
-		     <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>,
-		     <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>,
-		     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
-		     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
+			<GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>,
+			<GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>,
+			<GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
+			<GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
 	};
 };
 
diff --git a/arch/arm64/boot/dts/exynos/exynos8895-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos8895-pinctrl.dtsi
index 16903ce63a32d..4510b39c5e401 100644
--- a/arch/arm64/boot/dts/exynos/exynos8895-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos8895-pinctrl.dtsi
@@ -111,11 +111,11 @@ uart1_bus: uart1-bus-pins {
 	};
 
 	wlan_host_wake: wlan-host-wake-pins {
-		  samsung,pins = "gpa0-7";
-		  samsung,pin-function = <EXYNOS_PIN_FUNC_EINT>;
-		  samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
-		  samsung,pin-con-pdn = <EXYNOS_PIN_PDN_PREV>;
-		  samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_DOWN>;
+		samsung,pins = "gpa0-7";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_EINT>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+		samsung,pin-con-pdn = <EXYNOS_PIN_PDN_PREV>;
+		samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_DOWN>;
 	};
 };
 
-- 
2.43.0

[PATCH 12/16] arm64: dts: exynosautov920: Add space before line comments

[Waqar Hameed]

There should be a space before start of comment delimiter. Found/fixed
with dtfmt (Devicetree Source formatter).

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
 arch/arm64/boot/dts/exynos/exynosautov920.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
index 399b56b4dbdd9..d2b694a7e6f9d 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
@@ -265,7 +265,7 @@ l3_cache_cl0: l3-cache0 {
 			compatible = "cache";
 			cache-level = <3>;
 			cache-unified;
-			cache-size = <0x200000>;/* 2MB L3 cache for cpu cluster-0 */
+			cache-size = <0x200000>; /* 2MB L3 cache for cpu cluster-0 */
 			cache-line-size = <64>;
 			cache-sets = <2048>;
 		};
@@ -274,7 +274,7 @@ l3_cache_cl1: l3-cache1 {
 			compatible = "cache";
 			cache-level = <3>;
 			cache-unified;
-			cache-size = <0x200000>;/* 2MB L3 cache for cpu cluster-1 */
+			cache-size = <0x200000>; /* 2MB L3 cache for cpu cluster-1 */
 			cache-line-size = <64>;
 			cache-sets = <2048>;
 		};
@@ -283,7 +283,7 @@ l3_cache_cl2: l3-cache2 {
 			compatible = "cache";
 			cache-level = <3>;
 			cache-unified;
-			cache-size = <0x100000>;/* 1MB L3 cache for cpu cluster-2 */
+			cache-size = <0x100000>; /* 1MB L3 cache for cpu cluster-2 */
 			cache-line-size = <64>;
 			cache-sets = <1365>;
 		};
-- 
2.43.0

[PATCH 13/16] arm64: dts: exynosautov920: Add missing space in compatible

[Waqar Hameed]

Tabs should be a space between multiple property data. Found/fixed with
dtfmt (Devicetree Source formatter).

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
 arch/arm64/boot/dts/exynos/exynosautov920.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
index d2b694a7e6f9d..ba02fc28e42eb 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
@@ -1429,7 +1429,7 @@ wakeup-interrupt-controller {
 
 		pmu_system_controller: system-controller@11860000 {
 			compatible = "samsung,exynosautov920-pmu",
-				     "samsung,exynos7-pmu","syscon";
+				     "samsung,exynos7-pmu", "syscon";
 			reg = <0x11860000 0x10000>;
 		};
 
-- 
2.43.0

[PATCH 14/16] arm64: dts: exynosautov920: Remove empty line at end of node

[Waqar Hameed]

There shouldn't be an empty line at end of node definition. Found/fixed
with dtfmt (Devicetree Source formatter).

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
 arch/arm64/boot/dts/exynos/exynosautov920.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
index ba02fc28e42eb..65a75b18d3739 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
@@ -901,7 +901,6 @@ spi_8: spi@10980000 {
 
 				status = "disabled";
 			};
-
 		};
 
 		pwm: pwm@109b0000 {
-- 
2.43.0

[PATCH 15/16] arm64: dts: exynos: gs101: Use tabs for indentation

[Waqar Hameed]

Tabs should be used instead of whitespace for indentation. Found/fixed
with dtfmt (Devicetree Source formatter).

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
 arch/arm64/boot/dts/exynos/google/gs101.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
index bfceea5486f46..b67d98ff99fc4 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
+++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
@@ -1928,11 +1928,11 @@ apm_sram: sram@2039000 {
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts =
-		   <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>,
-		   <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>,
-		   <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>,
-		   <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>,
-		   <GIC_PPI 12 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>;
+			<GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>,
+			<GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>,
+			<GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>,
+			<GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>,
+			<GIC_PPI 12 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>;
 	};
 };
 
-- 
2.43.0

[PATCH 16/16] arm64: dts: exynos: gs101: Add space before line comments

[Waqar Hameed]

There should be a space before start of comment delimiter. Found/fixed
with dtfmt (Devicetree Source formatter).

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
 arch/arm64/boot/dts/exynos/google/gs101.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
index b67d98ff99fc4..1af8087838467 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
+++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
@@ -661,7 +661,7 @@ gic: interrupt-controller@10400000 {
 			#interrupt-cells = <4>;
 			interrupt-controller;
 			reg = <0x10400000 0x10000>, /* GICD */
-			      <0x10440000 0x100000>;/* GICR * 8 */
+			      <0x10440000 0x100000>; /* GICR * 8 */
 			interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH 0>;
 
 			ppi-partitions {
-- 
2.43.0

Re: [PATCH 00/16] arm64: dts: exynos: Format with dtfmt

[Krzysztof Kozlowski]

On 29/09/2026 00:38, Waqar Hameed wrote:
> I was looking through the notes for the last Devicetree microconference
> at Linux Plumbers (LPC) 2025 [1], and realized that the tool I have been
> working on might be of interest here: dtfmt - a Devicetree Source
> formatter [2].
> 
> dtfmt uses a parser with lexical grammar (tree-sitter) directly ported

We do not use dtfmt. I think you missed entire recent work and recent
commits, where `git log` would point you.

https://lore.kernel.org/all/20260911-b4-dts-samsung-cleanup-strict-continued-v1-0-9aa55051c42b@oss.qualcomm.com/

Best regards,
Krzysztof

Re: [PATCH 01/16] arm64: dts: exynos2200: Remove empty line at end of node

[Krzysztof Kozlowski]

On 29/09/2026 00:38, Waqar Hameed wrote:
> There shouldn't be an empty line at end of node definition. Found/fixed
> with dtfmt (Devicetree Source formatter).
> 
> Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos2200-pinctrl.dtsi | 2 --
>  arch/arm64/boot/dts/exynos/exynos2200.dtsi         | 1 -
>  2 files changed, 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos2200-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos2200-pinctrl.dtsi
> index 5877da7baf5c4..d5aede3af15f7 100644
> --- a/arch/arm64/boot/dts/exynos/exynos2200-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos2200-pinctrl.dtsi
> @@ -702,7 +702,6 @@ uart20_bus_dual: uart20-bus-dual-pins {
>  		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
>  		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
>  	};
> -
>  };

There is no such code.

Best regards,
Krzysztof

Re: (subset) [PATCH 09/16] arm64: dts: exynos8850: Add missing space in compatible

[Krzysztof Kozlowski]

On Tue, 29 Sep 2026 00:38:20 +0200, Waqar Hameed wrote:
> Tabs should be a space between multiple property data. Found/fixed with
> dtfmt (Devicetree Source formatter).

Applied, thanks!

[09/16] arm64: dts: exynos8850: Add missing space in compatible
        https://git.kernel.org/krzk/linux/c/0e5c0ebc0faeaa52da10feeb159dd8660a0b2f4b

Best regards,
-- 
Krzysztof Kozlowski <krzk@kernel.org>

Re: (subset) [PATCH 13/16] arm64: dts: exynosautov920: Add missing space in compatible

[Krzysztof Kozlowski]

On Tue, 29 Sep 2026 00:38:24 +0200, Waqar Hameed wrote:
> Tabs should be a space between multiple property data. Found/fixed with
> dtfmt (Devicetree Source formatter).

Applied, thanks!

[13/16] arm64: dts: exynosautov920: Add missing space in compatible
        (no commit info)

Best regards,
-- 
Krzysztof Kozlowski <krzk@kernel.org>