From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Alex Deucher <alexander.deucher@amd.com>
Cc: "Charlene Liu" <charlene.liu@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Harry Wentland" <harry.wentland@amd.com>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
"Dmytro Laktyushkin" <Dmytro.Laktyushkin@amd.com>,
"Vitaly Prosyak" <vitaly.prosyak@amd.com>,
"Yongqiang Sun" <yongqiang.sun@amd.com>,
"Tony Cheng" <tony.cheng@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/display: remove some unneeded code
Date: Mon, 6 Nov 2017 12:59:29 +0100 [thread overview]
Message-ID: <f1752f40-42fc-7c3e-38ae-50e1d3b1617b@gmail.com> (raw)
In-Reply-To: <20171106114422.sd5zoah6k6eaww4e@mwanda>
Am 06.11.2017 um 12:44 schrieb Dan Carpenter:
> We assign "v_init = asic_blank_start;" a few lines earlier so there is
> no need to do it again inside the if statements. Also "v_init" is
> unsigned so it can't be less than zero.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Christian König <christian.koenig@amd.com>
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c
> index 1994865d4351..c7333cdf1802 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c
> @@ -236,13 +236,10 @@ static void tgn10_program_timing(
> if (tg->dlg_otg_param.signal == SIGNAL_TYPE_DISPLAY_PORT ||
> tg->dlg_otg_param.signal == SIGNAL_TYPE_DISPLAY_PORT_MST ||
> tg->dlg_otg_param.signal == SIGNAL_TYPE_EDP) {
> - v_init = asic_blank_start;
> start_point = 1;
> if (patched_crtc_timing.flags.INTERLACE == 1)
> field_num = 1;
> }
> - if (v_init < 0)
> - v_init = 0;
> v_fp2 = 0;
> if (tg->dlg_otg_param.vstartup_start > asic_blank_end)
> v_fp2 = tg->dlg_otg_param.vstartup_start > asic_blank_end;
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-11-06 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 11:44 Dan Carpenter
2017-11-06 11:59 ` Christian König [this message]
2017-11-06 21:35 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1752f40-42fc-7c3e-38ae-50e1d3b1617b@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=Dmytro.Laktyushkin@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=charlene.liu@amd.com \
--cc=christian.koenig@amd.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.cheng@amd.com \
--cc=vitaly.prosyak@amd.com \
--cc=yongqiang.sun@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®