[PATCH] Export GPIO control symbols from mfp-pxa2xx.c

[PATCH] Export GPIO control symbols from mfp-pxa2xx.c

[Michael Abbott]

With very lightweight board support providing a number of uncommitted GPIO 
pins I found that my out of kernel driver needs to call symbols that 
aren't actually exported.  This patch adds these exports.


Date: Wed, 6 May 2009 12:47:22 +0100
Subject: [PATCH] Export GPIO control symbols from mfp-pxa2xx.c

This allows modules to configure their own GPIO settings if this hasn't
been done at the board level.

Signed-off-by: Michael Abbott <michael.abbott@diamond.ac.uk>
---
 arch/arm/mach-pxa/mfp-pxa2xx.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-pxa/mfp-pxa2xx.c b/arch/arm/mach-pxa/mfp-pxa2xx.c
index 33626de..3f2007a 100644
--- a/arch/arm/mach-pxa/mfp-pxa2xx.c
+++ b/arch/arm/mach-pxa/mfp-pxa2xx.c
@@ -384,3 +384,8 @@ static int __init pxa2xx_mfp_init(void)
 	return sysdev_class_register(&pxa2xx_mfp_sysclass);
 }
 postcore_initcall(pxa2xx_mfp_init);
+
+
+EXPORT_SYMBOL(pxa2xx_mfp_config);
+EXPORT_SYMBOL(pxa2xx_mfp_set_lpm);
+EXPORT_SYMBOL(gpio_set_wake);
-- 
1.6.1.3

Re: [PATCH] Export GPIO control symbols from mfp-pxa2xx.c

[Christoph Hellwig]

On Mon, May 11, 2009 at 07:43:29AM +0100, Michael Abbott wrote:
> With very lightweight board support providing a number of uncommitted GPIO 
> pins I found that my out of kernel driver needs to call symbols that 
> aren't actually exported.  This patch adds these exports.

As usual we don't export symbols for out of tree drivers.

Re: [PATCH] Export GPIO control symbols from mfp-pxa2xx.c

[Michael Abbott]

On Mon, 11 May 2009, Christoph Hellwig wrote:
> On Mon, May 11, 2009 at 07:43:29AM +0100, Michael Abbott wrote:
> > With very lightweight board support providing a number of uncommitted GPIO 
> > pins I found that my out of kernel driver needs to call symbols that 
> > aren't actually exported.  This patch adds these exports.
> As usual we don't export symbols for out of tree drivers.

I understand that's the default condition, but presumably there's no 
compelling reason for the mfp configuration functions to be withheld (I 
was simply trying to obey the obsolescence instructions in pxa2xx-gpio.h!)

As for bringing this driver in tree?  Not a great deal of point, in this 
particular case, but I have no problem with doing that.

P.S.  For anybody watching this with linux-arm-kernel access -- my 
messages are sticking despite having apparently subscribed...

Re: [PATCH] Export GPIO control symbols from mfp-pxa2xx.c

[Eric Miao]

On Mon, May 11, 2009 at 3:28 PM, Michael Abbott <michael@araneidae.co.uk> wrote:
> On Mon, 11 May 2009, Christoph Hellwig wrote:
>> On Mon, May 11, 2009 at 07:43:29AM +0100, Michael Abbott wrote:
>> > With very lightweight board support providing a number of uncommitted GPIO
>> > pins I found that my out of kernel driver needs to call symbols that
>> > aren't actually exported.  This patch adds these exports.
>> As usual we don't export symbols for out of tree drivers.
>
> I understand that's the default condition, but presumably there's no
> compelling reason for the mfp configuration functions to be withheld (I
> was simply trying to obey the obsolescence instructions in pxa2xx-gpio.h!)
>
> As for bringing this driver in tree?  Not a great deal of point, in this
> particular case, but I have no problem with doing that.
>

I don't see many real requirements here to export them for the moment.
By keeping these functions/symbols not-exported, I'd expect board-specific
code (usually manipulation of these pins are board-specific) to be kept
in the "board.c" as well, which I do think is a good practice.

Since your driver is out of the tree, you can certainly keep this change
out of the tree as well :-)

Re: [PATCH] Export GPIO control symbols from mfp-pxa2xx.c

[Michael Abbott]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1697 bytes --]

On Mon, 11 May 2009, Eric Miao wrote:
> On Mon, May 11, 2009 at 3:28 PM, Michael Abbott <michael@araneidae.co.uk> wrote:
> > On Mon, 11 May 2009, Christoph Hellwig wrote:
> >> On Mon, May 11, 2009 at 07:43:29AM +0100, Michael Abbott wrote:
> >> > With very lightweight board support providing a number of 
> >> > uncommitted GPIO pins I found that my out of kernel driver needs to 
> >> > call symbols that aren't actually exported.  This patch adds these 
> >> > exports.
> >> As usual we don't export symbols for out of tree drivers.
> >
> > I understand that's the default condition, but presumably there's no 
> > compelling reason for the mfp configuration functions to be withheld 
> > (I was simply trying to obey the obsolescence instructions in 
> > pxa2xx-gpio.h!)
> >
> > As for bringing this driver in tree?  Not a great deal of point, in 
> > this particular case, but I have no problem with doing that.
> 
> I don't see many real requirements here to export them for the moment. 
> By keeping these functions/symbols not-exported, I'd expect 
> board-specific code (usually manipulation of these pins are 
> board-specific) to be kept in the "board.c" as well, which I do think is 
> a good practice.

That's kind of fair, but in the case where the board is a CPU module 
rather than an entire system (which applies both for my XCEP module, the 
Colibri modules, and others I'm sure) this isn't necessarily so 
straightforward.

> Since your driver is out of the tree, you can certainly keep this change 
> out of the tree as well :-)

Heh.  There should be an emoticon for sticking my tongue out ;^).  Ok, I 
can live with that for the time being.