* [PATCH] arch/arm: adjust duplicate structure field initialization
@ 2009-09-16 9:06 Julia Lawall
2009-09-16 14:46 ` Eric Miao
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2009-09-16 9:06 UTC (permalink / raw)
To: Russell King, Eric Miao, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Currently the irq_type field of the csb726_lan_config structure is
initialized twice. The value in the first case,
SMSC911X_IRQ_POLARITY_ACTIVE_LOW, is normally stored in the irq_polarity
field, so I have renamed the field in the first initialization to that.
Signed-off-by: Julia Lawall <julia@diku.dk>
---
arch/arm/mach-pxa/csb726.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-pxa/csb726.c b/arch/arm/mach-pxa/csb726.c
index 79141f8..965480e 100644
--- a/arch/arm/mach-pxa/csb726.c
+++ b/arch/arm/mach-pxa/csb726.c
@@ -238,7 +238,7 @@ static struct resource csb726_lan_resources[] = {
};
struct smsc911x_platform_config csb726_lan_config = {
- .irq_type = SMSC911X_IRQ_POLARITY_ACTIVE_LOW,
+ .irq_polarity = SMSC911X_IRQ_POLARITY_ACTIVE_LOW,
.irq_type = SMSC911X_IRQ_TYPE_PUSH_PULL,
.flags = SMSC911X_USE_32BIT,
.phy_interface = PHY_INTERFACE_MODE_MII,
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] arch/arm: adjust duplicate structure field initialization
2009-09-16 9:06 [PATCH] arch/arm: adjust duplicate structure field initialization Julia Lawall
@ 2009-09-16 14:46 ` Eric Miao
0 siblings, 0 replies; 2+ messages in thread
From: Eric Miao @ 2009-09-16 14:46 UTC (permalink / raw)
To: Julia Lawall; +Cc: Russell King, linux-kernel, kernel-janitors
On Wed, Sep 16, 2009 at 5:06 PM, Julia Lawall <julia@diku.dk> wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Currently the irq_type field of the csb726_lan_config structure is
> initialized twice. The value in the first case,
> SMSC911X_IRQ_POLARITY_ACTIVE_LOW, is normally stored in the irq_polarity
> field, so I have renamed the field in the first initialization to that.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
Applied to 'fix'.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-09-16 14:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-16 9:06 [PATCH] arch/arm: adjust duplicate structure field initialization Julia Lawall
2009-09-16 14:46 ` Eric Miao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®