From: Eric Miao <eric.y.miao@gmail.com>
To: Ondrej Zajicek <santiago@crfreenet.org>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
marek.vasut@gmail.com
Subject: Re: [PATCH] 2.6.32-rc5 bug in Palm Tungsten C keyboard
Date: Tue, 27 Oct 2009 15:43:44 +0800 [thread overview]
Message-ID: <f17812d70910270043q328ab091mb1d76760e674450d@mail.gmail.com> (raw)
In-Reply-To: <20091026225930.GA18723@localhost>
On Tue, Oct 27, 2009 at 6:59 AM, Ondrej Zajicek <santiago@crfreenet.org> wrote:
> Palm Tungsten C keyboard structure has swapped
> rows/cols gpio structures and does not work.
> This patch fixes it.
>
> Signed-off-by: Ondrej Zajicek <santiago@crfreenet.org>
This fix looks obvious to me. Applied to 'fix'.
>
> diff -uprN linux-2.6.32-rc5-old/arch/arm/mach-pxa/palmtc.c linux-2.6.32-rc5/arch/arm/mach-pxa/palmtc.c
> --- linux-2.6.32-rc5-old/arch/arm/mach-pxa/palmtc.c 2009-10-16 02:41:50.000000000 +0200
> +++ linux-2.6.32-rc5/arch/arm/mach-pxa/palmtc.c 2009-10-26 20:56:44.000000000 +0100
> @@ -292,10 +292,10 @@ const static unsigned int palmtc_keypad_
>
> static struct matrix_keypad_platform_data palmtc_keypad_platform_data = {
> .keymap_data = &palmtc_keymap_data,
> - .col_gpios = palmtc_keypad_row_gpios,
> - .num_col_gpios = 12,
> - .row_gpios = palmtc_keypad_col_gpios,
> - .num_row_gpios = 4,
> + .row_gpios = palmtc_keypad_row_gpios,
> + .num_row_gpios = ARRAY_SIZE(palmtc_keypad_row_gpios),
> + .col_gpios = palmtc_keypad_col_gpios,
> + .num_col_gpios = ARRAY_SIZE(palmtc_keypad_col_gpios),
> .active_low = 1,
>
> .debounce_ms = 20,
>
>
> --
> Elen sila lumenn' omentielvo
>
> Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org)
> OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
> "To err is human -- to blame it on a computer is even more so."
>
next prev parent reply other threads:[~2009-10-27 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 22:59 Ondrej Zajicek
2009-10-27 7:43 ` Eric Miao [this message]
2009-10-28 1:37 ` Marek Vasut
2009-10-28 1:55 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d70910270043q328ab091mb1d76760e674450d@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=santiago@crfreenet.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®