From: Eric Miao <eric.y.miao@gmail.com>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: Ondrej Zajicek <santiago@crfreenet.org>,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH] 2.6.32-rc5 bug in Palm Tungsten C keyboard
Date: Wed, 28 Oct 2009 09:55:59 +0800 [thread overview]
Message-ID: <f17812d70910271855m4be6e4avcf90bfbbcb7ddb20@mail.gmail.com> (raw)
In-Reply-To: <200910280237.40268.marek.vasut@gmail.com>
On Wed, Oct 28, 2009 at 9:37 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> Dne Út 27. října 2009 08:43:44 Eric Miao napsal(a):
>> On Tue, Oct 27, 2009 at 6:59 AM, Ondrej Zajicek <santiago@crfreenet.org>
> wrote:
>> > Palm Tungsten C keyboard structure has swapped
>> > rows/cols gpio structures and does not work.
>> > This patch fixes it.
>> >
>> > Signed-off-by: Ondrej Zajicek <santiago@crfreenet.org>
>>
>> This fix looks obvious to me. Applied to 'fix'.
>
> Just wondering ... you checked the GPIO directions, right ? I mean, it works in
> both directions, it just works worse the other one. I can't really check now.
>
It would be good if you can have it checked and give your Ack please.
> Also, it'll be possibly good to use the following emails for pxa patches:
> Eric Miao <eric.y.miao@gmail.com>
> Linux-ARM-Kernel <linux-arm-kernel@lists.infradead.org>
> Marek Vasut <marek.vasut@gmail.com>
>
> Those should be enough.
>
> Cheers!
prev parent reply other threads:[~2009-10-28 1:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 22:59 Ondrej Zajicek
2009-10-27 7:43 ` Eric Miao
2009-10-28 1:37 ` Marek Vasut
2009-10-28 1:55 ` Eric Miao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d70910271855m4be6e4avcf90bfbbcb7ddb20@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=santiago@crfreenet.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome