From: Eric Miao <eric.y.miao@gmail.com>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: include only necessary in scripts/Makefile.modbuiltin
Date: Wed, 6 Jan 2010 18:31:13 +0800 [thread overview]
Message-ID: <f17812d71001060231l5c0ca1bha50e395790d0fc0b@mail.gmail.com> (raw)
In-Reply-To: <4B445D3E.8080600@suse.cz>
On Wed, Jan 6, 2010 at 5:51 PM, Michal Marek <mmarek@suse.cz> wrote:
> On 6.1.2010 07:26, Eric Miao wrote:
>> scripts/Makefile.modbuiltin assumes either Kbuild or Makefile exists in
>> every sub-directory, which is not true.
>
> It assumes what there is a kbuild file in each directory listed in
> subdir-[ym] or obj-[ym]. For which directory is this not true? Did you
> see an actual build failure? The same include is used in
> scripts/Makefile.build, where it has been working fine for ages...
>
Well, it's in my tree outside mainline, I have to make this change
to get it build. And'm wondering if that's a correct assumption.
next prev parent reply other threads:[~2010-01-06 10:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 6:26 Eric Miao
2010-01-06 9:51 ` Michal Marek
2010-01-06 10:31 ` Eric Miao [this message]
2010-01-06 10:39 ` Michal Marek
2010-01-06 11:22 ` Eric Miao
2010-01-06 11:47 ` Michal Marek
2010-01-06 11:59 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d71001060231l5c0ca1bha50e395790d0fc0b@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®