From: "Gotou, Yasunori/五島 康文" <y-goto@fujitsu.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: "Yang, Xiao/杨 晓" <yangx.jy@fujitsu.com>,
"Brian Foster" <bfoster@redhat.com>,
"hch@infradead.org" <hch@infradead.org>,
"Ruan, Shiyang/阮 世阳" <ruansy.fnst@fujitsu.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"david@fromorbit.com" <david@fromorbit.com>,
zwisler@kernel.org, "Jeff Moyer" <jmoyer@redhat.com>,
dm-devel@redhat.com, toshi.kani@hpe.com
Subject: Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition
Date: Mon, 3 Oct 2022 21:12:46 -0700 [thread overview]
Message-ID: <f196bcab-6aa2-6313-8a7c-f8ab409621b7@fujitsu.com> (raw)
In-Reply-To: <Yzt6eWLuX/RTjmjj@magnolia>
On 2022/10/03 17:12, Darrick J. Wong wrote:
> On Fri, Sep 30, 2022 at 09:56:41AM +0900, Gotou, Yasunori/五島 康文 wrote:
>> Hello everyone,
>>
>> On 2022/09/20 11:38, Yang, Xiao/杨 晓 wrote:
>>> Hi Darrick, Brian and Christoph
>>>
>>> Ping. I hope to get your feedback.
>>>
>>> 1) I have confirmed that the following patch set did not change the test
>>> result of generic/470 with thin-volume. Besides, I didn't see any
>>> failure when running generic/470 based on normal PMEM device instaed of
>>> thin-volume.
>>> https://lore.kernel.org/linux-xfs/20211129102203.2243509-1-hch@lst.de/
>>>
>>> 2) I can reproduce the failure of generic/482 without thin-volume.
>>>
>>> 3) Is it necessary to make thin-volume support DAX. Is there any use
>>> case for the requirement?
>>
>>
>> Though I asked other place(*), I really want to know the usecase of
>> dm-thin-volume with DAX and reflink.
>>
>>
>> In my understanding, dm-thin-volume seems to provide similar feature like
>> reflink of xfs. Both feature provide COW update to reduce usage of
>> its region, and snapshot feature, right?
>>
>> I found that docker seems to select one of them (or other feature which
>> supports COW). Then user don't need to use thin-volume and reflink at same
>> time.
>>
>> Database which uses FS-DAX may want to use snapshot for its data of FS-DAX,
>> its user seems to be satisfied with reflink or thin-volume.
>>
>> So I could not find on what use-case user would like to use dm-thin-volume
>> and reflink at same time.
>>
>> The only possibility is that the user has mistakenly configured dm-thinpool
>> and reflink to be used at the same time, but if that is the case, it seems
>> to be better for the user to disable one or the other.
>>
>> I really wander why dm-thin-volume must be used with reflik and FS-DAX.
>
> There isn't a hard requirement between fsdax and dm-thinp. The /test/
> needs dm-logwrites to check that write page faults on a MAP_SYNC
> mmapping are persisted directly to disk. dm-logwrites requires a fast
> way to zero an entire device for correct operation of the replay step,
> and thinp is the only way to guarantee that.
Thank you for your answer. But I still feel something is strange.
Though dm-thinp may be good way to execute the test correctly,
I suppose it seems to be likely a kind of workaround to pass the test,
it may not be really required for actual users.
Could you tell me why passing test by workaround is so necessary?
Thanks,
>
> --D
>
>> If my understanding is something wrong, please correct me.
>>
>> (*)https://lore.kernel.org/all/TYWPR01MB1008258F474CA2295B4CD3D9B90549@TYWPR01MB10082.jpnprd01.prod.outlook.com/
next prev parent reply other threads:[~2022-10-04 4:13 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 14:34 Shiyang Ruan
2022-06-10 5:46 ` Christoph Hellwig
2022-07-01 0:31 ` Darrick J. Wong
2022-07-01 5:14 ` Shiyang Ruan
2022-07-21 12:43 ` ruansy.fnst
2022-07-21 14:06 ` ruansy.fnst
2022-07-21 16:16 ` Darrick J. Wong
2022-07-29 3:55 ` ruansy.fnst
2022-07-29 4:54 ` Darrick J. Wong
2022-08-03 6:47 ` ruansy.fnst
2022-08-04 0:51 ` Darrick J. Wong
2022-08-04 1:36 ` Shiyang Ruan
2022-09-08 13:46 ` Shiyang Ruan
2022-09-09 13:01 ` Brian Foster
2022-09-14 6:44 ` Yang, Xiao/杨 晓
2022-09-14 9:38 ` Yang, Xiao/杨 晓
2022-09-14 12:34 ` Brian Foster
2022-09-14 16:28 ` Darrick J. Wong
2022-09-15 10:14 ` Yang, Xiao/杨 晓
2022-09-16 2:04 ` Yang, Xiao/杨 晓
2022-09-20 2:38 ` Yang, Xiao/杨 晓
2022-09-30 0:56 ` Gotou, Yasunori/五島 康文
2022-10-04 0:12 ` Darrick J. Wong
2022-10-04 4:12 ` Gotou, Yasunori/五島 康文 [this message]
2022-10-04 18:26 ` Darrick J. Wong
2022-10-20 14:17 ` Yang, Xiao/杨 晓
2022-10-22 2:11 ` Darrick J. Wong
[not found] ` <09f522cd-e846-12ee-d662-14f34a2977c4@fujitsu.com>
2022-10-23 7:04 ` yangx.jy
2022-10-23 22:00 ` Dave Chinner
2022-10-24 3:17 ` ruansy.fnst
2022-10-24 4:05 ` Darrick J. Wong
2022-10-24 5:31 ` Dave Chinner
2022-10-25 14:26 ` ruansy.fnst
2022-10-25 17:56 ` Darrick J. Wong
2022-10-27 21:08 ` Darrick J. Wong
2022-10-28 1:37 ` Dan Williams
2022-10-30 9:31 ` Shiyang Ruan
2022-11-02 0:45 ` Darrick J. Wong
2022-11-02 5:17 ` ruansy.fnst
2022-11-03 2:32 ` Dave Chinner
2022-10-24 17:12 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f196bcab-6aa2-6313-8a7c-f8ab409621b7@fujitsu.com \
--to=y-goto@fujitsu.com \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=ruansy.fnst@fujitsu.com \
--cc=toshi.kani@hpe.com \
--cc=yangx.jy@fujitsu.com \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®