From: Ivan Orlov <ivan.orlov0322@gmail.com>
To: ivan.orlov0322@gmail.com
Cc: perex@perex.cz, tiwai@suse.com, oswald.buddenhagen@gmx.de,
axboe@kernel.dk, 42.hyeyoo@gmail.com, surenb@google.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] ALSA: PCM: Fix codestyle issues in pcm_native.c
Date: Wed, 10 May 2023 11:55:18 +0400 [thread overview]
Message-ID: <f1a912ea-884b-fdcd-1c05-87089f1e97b7@gmail.com> (raw)
In-Reply-To: <2023051052-recoil-headache-1594@gregkh>
On 5/10/23 11:48, Greg KH wrote:
> - Your patch did many different things all at once, making it difficult
> to review. All Linux kernel patches need to only do one thing at a
> time. If you need to do multiple things (such as clean up all coding
> style issues in a file/driver), do it in a sequence of patches, each
> one doing only one thing. This will make it easier to review the
> patches to ensure that they are correct, and to help alleviate any
> merge issues that larger patches can cause.
>
> If you wish to discuss this problem further, or you have questions about
> how to resolve this issue, please feel free to respond to this email and
> Greg will reply once he has dug out from the pending patches received
> from other developers.
>
> thanks,
>
> greg k-h's patch email bot
Greg's Bot is right, it will be better as a sequence of patches. Sorry
for bothering!
Kind regards,
Ivan Orlov.
next prev parent reply other threads:[~2023-05-10 7:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 7:27 Ivan Orlov
2023-05-10 7:48 ` Greg KH
2023-05-10 7:55 ` Ivan Orlov [this message]
2023-05-10 8:06 ` Takashi Iwai
2023-05-10 8:21 ` Oswald Buddenhagen
2023-05-10 8:58 ` Takashi Iwai
2023-05-10 9:17 ` Ivan Orlov
2023-05-10 9:42 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1a912ea-884b-fdcd-1c05-87089f1e97b7@gmail.com \
--to=ivan.orlov0322@gmail.com \
--cc=42.hyeyoo@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oswald.buddenhagen@gmx.de \
--cc=perex@perex.cz \
--cc=surenb@google.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®