From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: Ivan Orlov <ivan.orlov0322@gmail.com>,
perex@perex.cz, tiwai@suse.com, axboe@kernel.dk,
42.hyeyoo@gmail.com, surenb@google.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] ALSA: PCM: Fix codestyle issues in pcm_native.c
Date: Wed, 10 May 2023 10:21:08 +0200 [thread overview]
Message-ID: <ZFtT9J0DQI9uSd1x@ugly> (raw)
In-Reply-To: <87a5yc626f.wl-tiwai@suse.de>
On Wed, May 10, 2023 at 10:06:16AM +0200, Takashi Iwai wrote:
>Also, if it's only about white space fix or some indent level issues,
>that could be rather more noise and disturbs the git change history,
>e.g. it makes difficult to find out the real code changes via git
>blame, especially it touches a huge amount of lines like this.
>
>That said, I'm not going to take such "coding style cleanup" patch
>blindly. If it's associated with other real fix or enhancement, I'll
>happily take it. Otherwise, I'd rather leave it.
>
a maybe less confusing way to put it would be "do whitespace cleanups
only on the lines that contain "real" changes, and maybe in their
immediate proximity for consistency". that means that whitespace-only
patches are by definition not acceptable.
regards
next prev parent reply other threads:[~2023-05-10 8:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 7:27 Ivan Orlov
2023-05-10 7:48 ` Greg KH
2023-05-10 7:55 ` Ivan Orlov
2023-05-10 8:06 ` Takashi Iwai
2023-05-10 8:21 ` Oswald Buddenhagen [this message]
2023-05-10 8:58 ` Takashi Iwai
2023-05-10 9:17 ` Ivan Orlov
2023-05-10 9:42 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFtT9J0DQI9uSd1x@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=42.hyeyoo@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=axboe@kernel.dk \
--cc=ivan.orlov0322@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=surenb@google.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®