From: Andrey Ryabinin <aryabinin@virtuozzo.com>
To: Andrey Konovalov <andreyknvl@google.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>, <kasan-dev@googlegroups.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<mingo@redhat.com>
Cc: <kcc@google.com>
Subject: Re: [PATCH 2/2] kasan: improve error reports
Date: Wed, 9 Nov 2016 19:23:18 +0300 [thread overview]
Message-ID: <f1f4d819-68e4-ff3d-d549-a53bcb60bec9@virtuozzo.com> (raw)
In-Reply-To: <12f35b740fd59901898c72c837600f5f4e1c2d56.1478632698.git.andreyknvl@google.com>
On 11/08/2016 10:37 PM, Andrey Konovalov wrote:
> 1. Change header format.
> 2. Unify header format between different kinds of bad accesses.
> 3. Add empty lines between parts of the report to improve readability.
> 4. Improve slab object description.
> 5. Improve mm/kasan/report.c readability.
>
Can you please do not dump everything in one patch? It only makes review process much more complicated.
Please break it up into 'one patch per logical change'.
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
> ---
prev parent reply other threads:[~2016-11-09 19:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 19:37 [PATCH 0/2] kasan,stacktrace: " Andrey Konovalov
2016-11-08 19:37 ` [PATCH 1/2] stacktrace: fix print_stack_trace printing timestamp twice Andrey Konovalov
2016-11-09 16:10 ` Andrey Ryabinin
2016-11-25 17:40 ` Dmitry Vyukov
2016-11-25 19:35 ` Joe Perches
2016-11-08 19:37 ` [PATCH 2/2] kasan: improve error reports Andrey Konovalov
2016-11-09 16:23 ` Andrey Ryabinin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1f4d819-68e4-ff3d-d549-a53bcb60bec9@virtuozzo.com \
--to=aryabinin@virtuozzo.com \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®