Re: [PATCH] kunit: time: use is_leap_year() helper

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

On Fri, Jan 30, 2026 at 03:11:17PM +0000, Mark Brown wrote:
> On Fri, Jan 23, 2026 at 04:09:40PM +0800, Jinjie Ruan wrote:
> 
> > Use the is_leap_year() helper from rtc.h instead of
> > writing it by hand

> This patch introduces a regression:

> > -static bool is_leap(long year)

> gets replaced by is_leap_year() which is:

> static inline bool is_leap_year(unsigned int year)

> which looks like it ought to work out the same from a quick look
> although it is written less clearly.  I'll look properly later when I've
> got through the rest of the pile of regressions.

The issue here is, of course, the change from using long for the new to
using unsigned long.  The test is considering times up to 8000 years
before 1970 which results in us trying to convert a negative year to a
positive value before testing if it's a leap year which gives us the
wrong answer.  I'll send a revert.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]