From: Mark Brown <broonie@kernel.org>
To: Thomas Gleixner <tglx@kernel.org>
Cc: Jinjie Ruan <ruanjinjie@huawei.com>,
jstultz@google.com, sboyd@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kunit: time: use is_leap_year() helper
Date: Sat, 31 Jan 2026 13:31:50 +0000 [thread overview]
Message-ID: <aX4ERvTINZ-_eivh@sirena.co.uk> (raw)
In-Reply-To: <87h5s2hkha.ffs@tglx>
[-- Attachment #1: Type: text/plain, Size: 617 bytes --]
On Fri, Jan 30, 2026 at 10:13:53PM +0100, Thomas Gleixner wrote:
> On Fri, Jan 30 2026 at 19:39, Mark Brown wrote:
> > The issue here is, of course, the change from using long for the new to
> > using unsigned long. The test is considering times up to 8000 years
> > before 1970 which results in us trying to convert a negative year to a
> > positive value before testing if it's a leap year which gives us the
> > wrong answer. I'll send a revert.
> Duh. Don't send anything I just zapped the commit from timers/core
OK, that also works just as well - I'd sent the patch before I saw this
mail, sorry. Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-01-31 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 8:09 Jinjie Ruan
2026-01-26 15:22 ` [tip: timers/core] time/kunit: Use " tip-bot2 for Jinjie Ruan
2026-01-30 15:11 ` [PATCH] kunit: time: use " Mark Brown
2026-01-30 19:39 ` Mark Brown
2026-01-30 21:13 ` Thomas Gleixner
2026-01-31 13:31 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aX4ERvTINZ-_eivh@sirena.co.uk \
--to=broonie@kernel.org \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=sboyd@kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®