From: Ping-Ke Shih <pkshih@realtek.com>
To: Luka Gejak <luka.gejak@linux.dev>, Hungyu Lin <dennylin0707@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rtl8821cerfe2@gmail.com" <rtl8821cerfe2@gmail.com>,
"straube.linux@gmail.com" <straube.linux@gmail.com>,
Hungyu Lin <dennylin0707@gmail.com>
Subject: RE: [PATCH v2] wifi: rtw88: 8723b: avoid converting RX SNR twice
Date: Mon, 12 Oct 2026 05:55:00 +0000 [thread overview]
Message-ID: <f2237c8130b047e4b212318c1b40bf75@realtek.com> (raw)
In-Reply-To: <ce5a3b408acc48642aa31866df39630aec7792f6@linux.dev>
Luka Gejak <luka.gejak@linux.dev> wrote:
> >
> > rtw8723b_query_phy_status_ofdm() divides the SNR report by two when
> > filling pkt_stat->rx_snr, then shifts it again when updating
> > dm_info->rx_snr. This halves the SNR used for diagnostics and average
> > statistics.
> >
> > Store the raw report in pkt_stat->rx_snr and convert it only when
> > updating dm_info->rx_snr, as the other chip drivers do.
> >
> > Fixes: d726c70ce082 ("wifi: rtw88: 8723b: add the RTL8723B chip driver")
> > Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>
> Ping-Ke should fixes tag be present here if this commit isn't in
> mainline yet?
My pull-request including the patch was merged, so the SHA1 will be constant.
Ping-Ke
prev parent reply other threads:[~2026-10-12 5:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 10:47 Hungyu Lin
2026-10-10 11:14 ` Luka Gejak
2026-10-12 5:55 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2237c8130b047e4b212318c1b40bf75@realtek.com \
--to=pkshih@realtek.com \
--cc=dennylin0707@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luka.gejak@linux.dev \
--cc=rtl8821cerfe2@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®