From: Andrew Lunn <andrew@lunn.ch>
To: Benjamin Schneider <bschnei@gmail.com>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Benjamin Schneider <ben@bens.haus>
Subject: Re: [PATCH] cpufreq: enable 1200Mhz clock speed for armada-37xx
Date: Mon, 3 Jun 2024 14:46:30 +0200 [thread overview]
Message-ID: <f2284d6b-2e75-4896-9e10-caf2f72854a0@lunn.ch> (raw)
In-Reply-To: <20240603012804.122215-2-ben@bens.haus>
On Sun, Jun 02, 2024 at 06:26:38PM -0700, Benjamin Schneider wrote:
> This frequency was disabled because of unresolved stability problems.
> However, based on several months of testing, the source of the
> stability problems seems to be the bootloader, not the kernel.
> Marvell has recently merged changes to their bootloader source that
> addresses the stability issues when frequency scaling is enabled at
> all frequencies including 1.2Ghz.
The problem is, most systems don't have the new bootloader. And so if
you enable 1.2GHz, they are going to be unstable.
Rather than making this unconditional, i think it needs to be
conditional on knowing the bootloader has been upgraded. Could you add
code which looks in the DDRPHY and see if 0xC0001004 has the correct
value. Only then enable the additional clock speed.
Andrew
next prev parent reply other threads:[~2024-06-03 12:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 1:26 Benjamin Schneider
2024-06-03 1:26 ` Benjamin Schneider
2024-06-03 12:46 ` Andrew Lunn [this message]
2024-06-03 19:33 ` Ben Schneider
2024-06-05 19:44 ` Pali Rohár
2024-06-05 23:44 ` Andrew Lunn
2024-07-11 16:59 ` Ben Schneider
2024-07-16 8:51 ` Gregory CLEMENT
2024-09-09 13:00 ` Ben Schneider
2024-10-13 3:01 ` Ben Schneider
2024-11-25 21:14 bschnei
2024-12-12 7:07 ` Viresh Kumar
2024-12-15 21:23 ` Marek Behún
2025-01-12 22:49 ` Ben Schneider
2025-02-03 10:57 ` Viresh Kumar
2025-02-19 5:52 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2284d6b-2e75-4896-9e10-caf2f72854a0@lunn.ch \
--to=andrew@lunn.ch \
--cc=ben@bens.haus \
--cc=bschnei@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®