Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements

[Dennis Dalessandro <dennis.dalessandro@intel.com>]

On 10/11/2017 11:31 AM, Dennis Dalessandro wrote:
> On 10/11/2017 8:41 AM, Thomas Bogendoerfer wrote:
>> Provide information about used firmware files via modinfo.
>>
>> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>> ---
>>   drivers/infiniband/hw/hfi1/firmware.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/infiniband/hw/hfi1/firmware.c 
>> b/drivers/infiniband/hw/hfi1/firmware.c
>> index dee3c674f33d..f56ace76b42c 100644
>> --- a/drivers/infiniband/hw/hfi1/firmware.c
>> +++ b/drivers/infiniband/hw/hfi1/firmware.c
>> @@ -70,6 +70,11 @@
>>   #define ALT_FW_PCIE_NAME "hfi1_pcie_d.fw"
>>   #define HOST_INTERFACE_VERSION 1
>> +MODULE_FIRMWARE(DEFAULT_FW_8051_NAME_ASIC);
>> +MODULE_FIRMWARE(DEFAULT_FW_FABRIC_NAME);
>> +MODULE_FIRMWARE(DEFAULT_FW_SBUS_NAME);
>> +MODULE_FIRMWARE(DEFAULT_FW_PCIE_NAME);
>> +
>>   static uint fw_8051_load = 1;
>>   static uint fw_fabric_serdes_load = 1;
>>   static uint fw_pcie_serdes_load = 1;
>>
> 
> I don't find this terribly useful, but if it's useful for you I'm sure 
> it is for others as well, so I have no problem with it.
> 
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>

Although you may want to change the subject from IB,hfi1 to IB/hfi1.