mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Resend [Patch 1/1] Trivial - kernel/time/ntp.c: fix warning
@ 2008-05-02 18:40 debian developer
  0 siblings, 0 replies; only message in thread
From: debian developer @ 2008-05-02 18:40 UTC (permalink / raw)
  To: kernelnewbies, LKML, kernel-janitors

Mailer spoilt the previous send... sorry for that
Hello,

On compiling on a Xeon machine i get the following warning

kernel/time/ntp.c: In function `do_adjtimex':
kernel/time/ntp.c:328: warning: comparison of distinct pointer types
lacks a cast
kernel/time/ntp.c:329: warning: comparison of distinct pointer types
lacks a cast

This is with gcc version 3.4.3. The following patch fixes this...

--- linux-2.6.25/kernel/time/ntp.c.orig 2008-05-03 04:27:20.000000000 +0530
+++ linux-2.6.25/kernel/time/ntp.c      2008-05-03 04:45:06.000000000 +0530
@@ -325,8 +325,8 @@ int do_adjtimex(struct timex *txc)
                    * Scale the phase adjustment and
                    * clamp to the operating range.
                    */
-                   time_offset = min(time_offset, (s64)MAXPHASE *
NSEC_PER_USEC);
-                   time_offset = max(time_offset, (s64)-MAXPHASE *
NSEC_PER_USEC);
+                   time_offset = min(time_offset, (s64)(MAXPHASE *
NSEC_PER_USEC));
+                   time_offset = max(time_offset, (s64)(-MAXPHASE *
NSEC_PER_USEC));

                   /*
                    * Select whether the frequency is to be controlled

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-05-02 18:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-05-02 18:40 Resend [Patch 1/1] Trivial - kernel/time/ntp.c: fix warning debian developer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®