mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yu-Chun Lin [林祐君]" <eleanor.lin@realtek.com>
To: "Pengpeng Hou" <hppiscas@163.com>,
	"James Tai [戴志峰]" <james.tai@realtek.com>
Cc: "afaerber@suse.com" <afaerber@suse.com>,
	"linusw@kernel.org" <linusw@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-realtek-soc@lists.infradead.org"
	<linux-realtek-soc@lists.infradead.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"TY_Chang[張子逸]" <tychang@realtek.com>
Subject: RE: [PATCH v2] pinctrl: realtek: rtd1619b: publish the OF module alias
Date: Mon, 28 Sep 2026 15:00:29 +0000	[thread overview]
Message-ID: <f25e75dabbf64d3a9078ea584aee7986@realtek.com> (raw)
In-Reply-To: <20260920033520.12924-1-hppiscas@163.com>

> PINCTRL_RTD1619B is tristate, and the driver uses the realtek,rtd1619b-pinctrl
> compatible to match its devices. However, the OF table is not exported, so a
> modular build does not advertise this alias for automatic module loading.
> 
> Add the OF export without changing probe or registration ordering.
> 
> The issue was found by our static-analysis tool.
> 
> Fixes: c7910f6aca56 ("pinctrl: realtek: Add pinctrl driver for RTD1619B")
> Assisted-by: gpt 5
> Signed-off-by: Pengpeng Hou <hppiscas@163.com>

Acked-by: Yu-Chun Lin <eleanor.lin@realtek.com>

> ---
> Changes since v1:
> https://lore.kernel.org/all/20260905134418.67619-1-hppiscas@163.com/
> Use the full author name and regenerate the plain-text inline diff without
> embedded carriage returns.
> 
>  drivers/pinctrl/realtek/pinctrl-rtd1619b.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
> b/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
> index b07e50d6356d..e03e1fb09899 100644
> --- a/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
> +++ b/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
> @@ -1575,6 +1575,7 @@ static const struct of_device_id
> rtd1619b_pinctrl_of_match[] = {
>         { .compatible = "realtek,rtd1619b-pinctrl", },
>         {},
>  };
> +MODULE_DEVICE_TABLE(of, rtd1619b_pinctrl_of_match);
> 
>  static struct platform_driver rtd1619b_pinctrl_driver = {
>         .driver = {
> 
> base-commit: 518e5b794c06c0f0eb40df3e202274a66202c137
> --
> 2.50.1 (Apple Git-155)


      reply	other threads:[~2026-09-28 15:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-20  3:35 Pengpeng Hou
2026-09-28 15:00 ` Yu-Chun Lin [林祐君] [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f25e75dabbf64d3a9078ea584aee7986@realtek.com \
    --to=eleanor.lin@realtek.com \
    --cc=afaerber@suse.com \
    --cc=hppiscas@163.com \
    --cc=james.tai@realtek.com \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-realtek-soc@lists.infradead.org \
    --cc=tychang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®