mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] pinctrl: realtek: rtd1619b: publish the OF module alias
@ 2026-09-20  3:35 Pengpeng Hou
  2026-09-28 15:00 ` Yu-Chun Lin [林祐君]
  0 siblings, 1 reply; 2+ messages in thread
From: Pengpeng Hou @ 2026-09-20  3:35 UTC (permalink / raw)
  To: james.tai
  Cc: eleanor.lin, afaerber, linusw, linux-arm-kernel,
	linux-realtek-soc, linux-gpio, linux-kernel, tychang, hppiscas

PINCTRL_RTD1619B is tristate, and the driver uses the
realtek,rtd1619b-pinctrl compatible to match its devices. However, the
OF table is not exported, so a modular build does not advertise this
alias for automatic module loading.

Add the OF export without changing probe or registration ordering.

The issue was found by our static-analysis tool.

Fixes: c7910f6aca56 ("pinctrl: realtek: Add pinctrl driver for RTD1619B")
Assisted-by: gpt 5
Signed-off-by: Pengpeng Hou <hppiscas@163.com>
---
Changes since v1:
https://lore.kernel.org/all/20260905134418.67619-1-hppiscas@163.com/
Use the full author name and regenerate the plain-text inline diff
without embedded carriage returns.

 drivers/pinctrl/realtek/pinctrl-rtd1619b.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/realtek/pinctrl-rtd1619b.c b/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
index b07e50d6356d..e03e1fb09899 100644
--- a/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
+++ b/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
@@ -1575,6 +1575,7 @@ static const struct of_device_id rtd1619b_pinctrl_of_match[] = {
 	{ .compatible = "realtek,rtd1619b-pinctrl", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, rtd1619b_pinctrl_of_match);
 
 static struct platform_driver rtd1619b_pinctrl_driver = {
 	.driver = {

base-commit: 518e5b794c06c0f0eb40df3e202274a66202c137
-- 
2.50.1 (Apple Git-155)


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH v2] pinctrl: realtek: rtd1619b: publish the OF module alias
  2026-09-20  3:35 [PATCH v2] pinctrl: realtek: rtd1619b: publish the OF module alias Pengpeng Hou
@ 2026-09-28 15:00 ` Yu-Chun Lin [林祐君]
  0 siblings, 0 replies; 2+ messages in thread
From: Yu-Chun Lin [林祐君] @ 2026-09-28 15:00 UTC (permalink / raw)
  To: Pengpeng Hou, James Tai [戴志峰]
  Cc: afaerber, linusw, linux-arm-kernel, linux-realtek-soc,
	linux-gpio, linux-kernel, TY_Chang[張子逸]

> PINCTRL_RTD1619B is tristate, and the driver uses the realtek,rtd1619b-pinctrl
> compatible to match its devices. However, the OF table is not exported, so a
> modular build does not advertise this alias for automatic module loading.
> 
> Add the OF export without changing probe or registration ordering.
> 
> The issue was found by our static-analysis tool.
> 
> Fixes: c7910f6aca56 ("pinctrl: realtek: Add pinctrl driver for RTD1619B")
> Assisted-by: gpt 5
> Signed-off-by: Pengpeng Hou <hppiscas@163.com>

Acked-by: Yu-Chun Lin <eleanor.lin@realtek.com>

> ---
> Changes since v1:
> https://lore.kernel.org/all/20260905134418.67619-1-hppiscas@163.com/
> Use the full author name and regenerate the plain-text inline diff without
> embedded carriage returns.
> 
>  drivers/pinctrl/realtek/pinctrl-rtd1619b.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
> b/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
> index b07e50d6356d..e03e1fb09899 100644
> --- a/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
> +++ b/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
> @@ -1575,6 +1575,7 @@ static const struct of_device_id
> rtd1619b_pinctrl_of_match[] = {
>         { .compatible = "realtek,rtd1619b-pinctrl", },
>         {},
>  };
> +MODULE_DEVICE_TABLE(of, rtd1619b_pinctrl_of_match);
> 
>  static struct platform_driver rtd1619b_pinctrl_driver = {
>         .driver = {
> 
> base-commit: 518e5b794c06c0f0eb40df3e202274a66202c137
> --
> 2.50.1 (Apple Git-155)


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-28 15:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-20  3:35 [PATCH v2] pinctrl: realtek: rtd1619b: publish the OF module alias Pengpeng Hou
2026-09-28 15:00 ` Yu-Chun Lin [林祐君]

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®