mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Hung <alex.hung@amd.com>
To: kyliepc@proton.me, "Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Rodrigo Siqueira" <siqueira@igalia.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amd/display: Don't select zero V_TOTAL_MIN/MAX on DCN2 seamless boot
Date: Fri, 30 Oct 2026 19:58:17 -0600	[thread overview]
Message-ID: <f25f4726-17c1-4fdf-8fd2-d96e73fbb22a@amd.com> (raw)
In-Reply-To: <20261022-dcn2-seamless-vtotal-v1-1-6ceb87f98629@proton.me>

This affects more than DCN2, but I can fix patch title by removing "DCN2".

Reviewed-by: Alex Hung <alex.hung@amd.com>

On 10/22/26 07:30, Kylie C via B4 Relay wrote:
> [Some people who received this message don't often get email from devnull+kyliepc.proton.me@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> From: Kylie C <kyliepc@proton.me>
> 
> Initialize V_TOTAL_MIN/MAX to V_TOTAL before enabling the selectors if
> they are still 0, as optc1_program_timing() does without seamless boot.
> 
> Tested on Renoir (DCN 2.1) eDP with amdgpu.seamless=1.
> 
> This removes the flash between the bios logo & plymouth on my laptop.
> 
> Signed-off-by: Kylie C <kyliepc@proton.me>
> ---
> Fixes the black screen when enabling amdgpu.seamless=1 on Renoir APU
> 
> With this plymouth smooth boot is possible on this hardware
> ---
>   drivers/gpu/drm/amd/display/dc/optc/dcn20/dcn20_optc.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/optc/dcn20/dcn20_optc.c b/drivers/gpu/drm/amd/display/dc/optc/dcn20/dcn20_optc.c
> index 73cc8a713..2cdfe3d7a 100644
> --- a/drivers/gpu/drm/amd/display/dc/optc/dcn20/dcn20_optc.c
> +++ b/drivers/gpu/drm/amd/display/dc/optc/dcn20/dcn20_optc.c
> @@ -449,6 +449,13 @@ void optc2_lock_doublebuffer_disable(struct timing_generator *optc)
>   void optc2_setup_manual_trigger(struct timing_generator *optc)
>   {
>          struct optc *optc1 = DCN10TG_FROM_TG(optc);
> +       uint32_t v_total, v_total_max;
> +
> +       REG_GET(OTG_V_TOTAL_MAX, OTG_V_TOTAL_MAX, &v_total_max);
> +       if (!v_total_max) {
> +               REG_GET(OTG_V_TOTAL, OTG_V_TOTAL, &v_total);
> +               optc->funcs->set_vtotal_min_max(optc, v_total, v_total);
> +       }
> 
>          /* Set the min/max selectors unconditionally so that
>           * DMCUB fw may change OTG timings when necessary
> 
> ---
> base-commit: 77f548b127c6de34ce271fa09ba270cb1ef9f2da
> change-id: 20261022-dcn2-seamless-vtotal-351d08d2df54
> 
> Best regards,
> --
> Kylie C <kyliepc@proton.me>


      reply	other threads:[~2026-10-31  1:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22 13:30 Kylie C via B4 Relay
2026-10-31  1:58 ` Alex Hung [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f25f4726-17c1-4fdf-8fd2-d96e73fbb22a@amd.com \
    --to=alex.hung@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=kyliepc@proton.me \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=siqueira@igalia.com \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®