* [PATCH] NTB: ntb_tool: Add check for devm_kcalloc
@ 2022-11-22 3:32 Jiasheng Jiang
2022-11-25 11:49 ` Serge Semin
2022-11-28 15:37 ` Dave Jiang
0 siblings, 2 replies; 5+ messages in thread
From: Jiasheng Jiang @ 2022-11-22 3:32 UTC (permalink / raw)
To: jdmason, dave.jiang, allenbh, error27; +Cc: ntb, linux-kernel, Jiasheng Jiang
As the devm_kcalloc may return NULL pointer,
it should be better to add check for the return
value, as same as the others.
Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/ntb/test/ntb_tool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
index 5ee0afa621a9..eeeb4b1c97d2 100644
--- a/drivers/ntb/test/ntb_tool.c
+++ b/drivers/ntb/test/ntb_tool.c
@@ -998,6 +998,8 @@ static int tool_init_mws(struct tool_ctx *tc)
tc->peers[pidx].outmws =
devm_kcalloc(&tc->ntb->dev, tc->peers[pidx].outmw_cnt,
sizeof(*tc->peers[pidx].outmws), GFP_KERNEL);
+ if (tc->peers[pidx].outmws == NULL)
+ return -ENOMEM;
for (widx = 0; widx < tc->peers[pidx].outmw_cnt; widx++) {
tc->peers[pidx].outmws[widx].pidx = pidx;
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] NTB: ntb_tool: Add check for devm_kcalloc
2022-11-22 3:32 [PATCH] NTB: ntb_tool: Add check for devm_kcalloc Jiasheng Jiang
@ 2022-11-25 11:49 ` Serge Semin
2022-11-28 15:37 ` Dave Jiang
1 sibling, 0 replies; 5+ messages in thread
From: Serge Semin @ 2022-11-25 11:49 UTC (permalink / raw)
To: Jiasheng Jiang; +Cc: jdmason, dave.jiang, allenbh, error27, ntb, linux-kernel
On Tue, Nov 22, 2022 at 11:32:44AM +0800, Jiasheng Jiang wrote:
> As the devm_kcalloc may return NULL pointer,
> it should be better to add check for the return
> value, as same as the others.
>
> Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Right. Thanks!
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
-Sergey
> ---
> drivers/ntb/test/ntb_tool.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
> index 5ee0afa621a9..eeeb4b1c97d2 100644
> --- a/drivers/ntb/test/ntb_tool.c
> +++ b/drivers/ntb/test/ntb_tool.c
> @@ -998,6 +998,8 @@ static int tool_init_mws(struct tool_ctx *tc)
> tc->peers[pidx].outmws =
> devm_kcalloc(&tc->ntb->dev, tc->peers[pidx].outmw_cnt,
> sizeof(*tc->peers[pidx].outmws), GFP_KERNEL);
> + if (tc->peers[pidx].outmws == NULL)
> + return -ENOMEM;
>
> for (widx = 0; widx < tc->peers[pidx].outmw_cnt; widx++) {
> tc->peers[pidx].outmws[widx].pidx = pidx;
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] NTB: ntb_tool: Add check for devm_kcalloc
2022-11-22 3:32 [PATCH] NTB: ntb_tool: Add check for devm_kcalloc Jiasheng Jiang
2022-11-25 11:49 ` Serge Semin
@ 2022-11-28 15:37 ` Dave Jiang
1 sibling, 0 replies; 5+ messages in thread
From: Dave Jiang @ 2022-11-28 15:37 UTC (permalink / raw)
To: Jiasheng Jiang, jdmason, allenbh, error27; +Cc: ntb, linux-kernel
On 11/21/2022 8:32 PM, Jiasheng Jiang wrote:
> As the devm_kcalloc may return NULL pointer,
> it should be better to add check for the return
> value, as same as the others.
>
> Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/ntb/test/ntb_tool.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
> index 5ee0afa621a9..eeeb4b1c97d2 100644
> --- a/drivers/ntb/test/ntb_tool.c
> +++ b/drivers/ntb/test/ntb_tool.c
> @@ -998,6 +998,8 @@ static int tool_init_mws(struct tool_ctx *tc)
> tc->peers[pidx].outmws =
> devm_kcalloc(&tc->ntb->dev, tc->peers[pidx].outmw_cnt,
> sizeof(*tc->peers[pidx].outmws), GFP_KERNEL);
> + if (tc->peers[pidx].outmws == NULL)
> + return -ENOMEM;
>
> for (widx = 0; widx < tc->peers[pidx].outmw_cnt; widx++) {
> tc->peers[pidx].outmws[widx].pidx = pidx;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] NTB: ntb_tool: Add check for devm_kcalloc
@ 2022-11-22 3:34 Jiasheng Jiang
0 siblings, 0 replies; 5+ messages in thread
From: Jiasheng Jiang @ 2022-11-22 3:34 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, michal.simek, harini.katakam,
xuhaoyue1, huangjunxian6, wangqing, christophe.jaillet,
yangyingliang, chenhao288
Cc: netdev, linux-arm-kernel, linux-kernel, Jiasheng Jiang
Sorry, I sent the wrong email.
Please ignore it.
Jiang
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] NTB: ntb_tool: Add check for devm_kcalloc
@ 2022-11-22 3:30 Jiasheng Jiang
0 siblings, 0 replies; 5+ messages in thread
From: Jiasheng Jiang @ 2022-11-22 3:30 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, michal.simek, harini.katakam,
xuhaoyue1, huangjunxian6, wangqing, christophe.jaillet,
yangyingliang, chenhao288
Cc: netdev, linux-arm-kernel, linux-kernel, Jiasheng Jiang
As the devm_kcalloc may return NULL pointer,
it should be better to add check for the return
value, as same as the others.
Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/ntb/test/ntb_tool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
index 5ee0afa621a9..eeeb4b1c97d2 100644
--- a/drivers/ntb/test/ntb_tool.c
+++ b/drivers/ntb/test/ntb_tool.c
@@ -998,6 +998,8 @@ static int tool_init_mws(struct tool_ctx *tc)
tc->peers[pidx].outmws =
devm_kcalloc(&tc->ntb->dev, tc->peers[pidx].outmw_cnt,
sizeof(*tc->peers[pidx].outmws), GFP_KERNEL);
+ if (tc->peers[pidx].outmws == NULL)
+ return -ENOMEM;
for (widx = 0; widx < tc->peers[pidx].outmw_cnt; widx++) {
tc->peers[pidx].outmws[widx].pidx = pidx;
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-28 15:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22 3:32 [PATCH] NTB: ntb_tool: Add check for devm_kcalloc Jiasheng Jiang
2022-11-25 11:49 ` Serge Semin
2022-11-28 15:37 ` Dave Jiang
-- strict thread matches above, loose matches on Subject: below --
2022-11-22 3:34 Jiasheng Jiang
2022-11-22 3:30 Jiasheng Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®