* [PATCH v2] erofs: remove dead code in erofs_fc_parse_param
@ 2025-01-17 10:06 Chen Linxuan
2025-01-17 11:40 ` Gao Xiang
0 siblings, 1 reply; 2+ messages in thread
From: Chen Linxuan @ 2025-01-17 10:06 UTC (permalink / raw)
To: Gao Xiang, Chao Yu, Yue Hu, Jeffle Xu, Sandeep Dhavale
Cc: Chen Linxuan, linux-erofs, linux-kernel
If an option is unknown to erofs, which means that option is not in
`erofs_fs_parameters`, `fs_parse` will return -ENOPARAM, which makes
`erofs_fc_parse_param` returns earlier.
Signed-off-by: Chen Linxuan <chenlinxuan@uniontech.com>
---
Change Log:
v1->v2: Improve "erofs: add error log in erofs_fc_parse_param"
---
fs/erofs/super.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 1fc5623c3a4d..827b62665649 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -508,8 +508,6 @@ static int erofs_fc_parse_param(struct fs_context *fc,
errorfc(fc, "%s option not supported", erofs_fs_parameters[opt].name);
#endif
break;
- default:
- return -ENOPARAM;
}
return 0;
}
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] erofs: remove dead code in erofs_fc_parse_param
2025-01-17 10:06 [PATCH v2] erofs: remove dead code in erofs_fc_parse_param Chen Linxuan
@ 2025-01-17 11:40 ` Gao Xiang
0 siblings, 0 replies; 2+ messages in thread
From: Gao Xiang @ 2025-01-17 11:40 UTC (permalink / raw)
To: Chen Linxuan, Gao Xiang, Chao Yu, Yue Hu, Jeffle Xu, Sandeep Dhavale
Cc: linux-erofs, linux-kernel
On 2025/1/17 18:06, Chen Linxuan wrote:
> If an option is unknown to erofs, which means that option is not in
> `erofs_fs_parameters`, `fs_parse` will return -ENOPARAM, which makes
> `erofs_fc_parse_param` returns earlier.
>
> Signed-off-by: Chen Linxuan <chenlinxuan@uniontech.com>
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Thanks,
Gao Xiang
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-17 11:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-17 10:06 [PATCH v2] erofs: remove dead code in erofs_fc_parse_param Chen Linxuan
2025-01-17 11:40 ` Gao Xiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®