mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Karthik S <karthik.s@oss.qualcomm.com>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: pinctrl: qcom: Add QCS615 LPASS LPI pinctrl bindings
Date: Tue, 17 Nov 2026 11:21:36 +0100	[thread overview]
Message-ID: <f290ccf7-1475-44c2-8152-b88db79d46fb@kernel.org> (raw)
In-Reply-To: <20261117075100.272535-2-karthik.s@oss.qualcomm.com>

On 17/11/2026 08:50, Karthik S wrote:

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23

> +    properties:
> +      pins:
> +        description:
> +          List of gpio pins affected by the properties specified in this
> +          subnode.
> +        items:
> +          pattern: "^gpio([0-9]|1[0-9]|2[0-9]|3[0-1])$"
> +
> +      function:
> +        enum: [ dmic1_clk, dmic1_data, dmic2_clk, dmic2_data, gpio, i2s1_clk,
> +                i2s1_data, i2s1_ws, spkr_i2s_mclk_a ]

It's the first time spkr_i2s_mclk_a name appears. Are you sure that is
the name of the pin function in the datasheet? You won't be able to
change it later.



Best regards,
Krzysztof

  reply	other threads:[~2026-11-17 10:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  7:50 [PATCH v2 0/3] pinctrl: qcom: Add QCS615 LPASS LPI pinctrl support Karthik S
2026-11-17  7:50 ` [PATCH v2 1/3] dt-bindings: pinctrl: qcom: Add QCS615 LPASS LPI pinctrl bindings Karthik S
2026-11-17 10:21   ` Krzysztof Kozlowski [this message]
2026-11-17  7:50 ` [PATCH v2 2/3] pinctrl: qcom: Add qcs615 lpass lpi pinctrl driver Karthik S
2026-11-17 10:14   ` Krzysztof Kozlowski
2026-11-17  7:51 ` [PATCH v2 3/3] arm64: defconfig: Enable QCS615 LPASS LPI pinctrl Karthik S
2026-11-17 10:16   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f290ccf7-1475-44c2-8152-b88db79d46fb@kernel.org \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=karthik.s@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®