From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Madadi Vineeth Reddy <vineethr@linux.ibm.com>
Cc: <bsegall@google.com>, <dietmar.eggemann@arm.com>,
<gautham.shenoy@amd.com>, <juri.lelli@redhat.com>,
<linux-kernel@vger.kernel.org>, <mgorman@suse.de>,
<mingo@redhat.com>, <peterz@infradead.org>, <rostedt@goodmis.org>,
<swapnil.sapkal@amd.com>, <vincent.guittot@linaro.org>,
<vschneid@redhat.com>
Subject: Re: [PATCH] sched/fair: Fix inaccurate h_nr_runnable accounting with delayed dequeue
Date: Mon, 20 Jan 2025 14:44:47 +0530 [thread overview]
Message-ID: <f2acd84b-a102-487a-b7c1-3ce1e85dee1f@amd.com> (raw)
In-Reply-To: <20250120084441.17746-1-vineethr@linux.ibm.com>
On 1/20/2025 2:14 PM, Madadi Vineeth Reddy wrote:
>> However, I was unable to trigger the WARN_ON by running hackbench in a
>> cgroup without the patch. Could you please share the specific test
>> scenario or configuration you used to reproduce it?
>
> My mistake: SCHED_WARN_ON is a WARN_ONCE, so I had to clear it before
> running hackbench to ensure the WARN_ON could be triggered again.
Yup! A WARN_ON() is hit very consistently.
>
> Now I am able to trigger the WARN_ON in the unpatched kernel while
> running hackbench after executing `echo 1 > /sys/kernel/debug/clear_warn_once`
> following the initial warning during the boot process. I have verified
> that the patched kernel fixes the issue.
Thank you again for testing the fix. Much appreciated!
>
> Thanks,
> Madadi Vineeth Reddy
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2025-01-20 9:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 10:58 K Prateek Nayak
2025-01-17 13:25 ` Vincent Guittot
2025-01-17 15:59 ` K Prateek Nayak
2025-01-18 8:30 ` Vincent Guittot
2025-01-21 8:09 ` K Prateek Nayak
2025-01-21 9:53 ` Vincent Guittot
2025-01-20 5:06 ` Madadi Vineeth Reddy
2025-01-20 8:44 ` Madadi Vineeth Reddy
2025-01-20 9:14 ` K Prateek Nayak [this message]
2025-01-20 9:12 ` K Prateek Nayak
2025-01-21 12:21 ` [tip: sched/urgent] " tip-bot2 for K Prateek Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2acd84b-a102-487a-b7c1-3ce1e85dee1f@amd.com \
--to=kprateek.nayak@amd.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=gautham.shenoy@amd.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=swapnil.sapkal@amd.com \
--cc=vincent.guittot@linaro.org \
--cc=vineethr@linux.ibm.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome