From: Dan Carpenter <dan.carpenter@linaro.org>
To: Christian Lamparter <chunkeey@gmail.com>,
Shiji Yang <yangshiji66@qq.com>
Cc: Linux Wireless <linux-wireless@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
Wu Yunchuan <yunchuan@nfschina.com>,
Jeff Johnson <quic_jjohnson@quicinc.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Kalle Valo <kvalo@kernel.org>
Subject: Re: [PATCH v2 wireless-next 2/9] carl9170: remove unnecessary (void*) conversions
Date: Fri, 29 Sep 2023 15:30:40 +0300 [thread overview]
Message-ID: <f2e567f3-97ff-494a-b25c-b5d12652b034@kadam.mountain> (raw)
In-Reply-To: <721a4c53-a253-4b0e-a5e0-fc4b992feb49@kadam.mountain>
On Fri, Sep 29, 2023 at 03:26:17PM +0300, Dan Carpenter wrote:
> On Fri, Sep 29, 2023 at 09:23:26AM +0200, Christian Lamparter wrote:
> > I would like to take the chance to again point to this beauty:
> > <https://lore.kernel.org/linux-wireless/TYAP286MB03154F9AAFD4C35BEEDE4A99BC4CA@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM/T/#mf1b8919a000fe661803c17073f48b3c410888541>
> > @Dan, @Jeff can you please comment on that too?
>
> I don't know how Shiji Yang generated this warning. The warning doesn't
> make sense and I don't see how the patch helps. I tested with GCC (v12)
> and Clang (random from git) and neither one generates a warning. What's
> the point of having all the struct members in a group when struct itself
> already forms a group?
>
> #confused
Wait, all this was in the email thread from June but I didn't scroll
down beyond the end of the patch... It was just a compiler bug in a
GCC dot release.
regards,
dan carpenter
next prev parent reply other threads:[~2023-09-29 12:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 4:49 Wu Yunchuan
2023-09-20 18:15 ` Jeff Johnson
2023-09-20 19:00 ` Christian Lamparter
2023-09-22 1:33 ` yunchuan
2023-09-28 15:31 ` Kalle Valo
2023-09-28 19:26 ` Jeff Johnson
2023-09-29 6:43 ` Dan Carpenter
2023-09-29 6:49 ` Dan Carpenter
2023-09-29 7:23 ` Christian Lamparter
2023-09-29 12:26 ` Dan Carpenter
2023-09-29 12:30 ` Dan Carpenter [this message]
2023-09-29 16:10 ` Jeff Johnson
2023-09-29 17:22 ` Jeff Johnson
2023-10-02 16:57 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2e567f3-97ff-494a-b25c-b5d12652b034@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=chunkeey@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=yangshiji66@qq.com \
--cc=yunchuan@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®