mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] audit: log module name on delete_module
@ 2017-03-12  2:24 Richard Guy Briggs
  2017-03-13 14:16 ` Paul Moore
  0 siblings, 1 reply; 4+ messages in thread
From: Richard Guy Briggs @ 2017-03-12  2:24 UTC (permalink / raw)
  To: linux-kernel, linux-audit
  Cc: Richard Guy Briggs, Jessica Yu, Eric Paris, Paul Moore, Steve Grubb

When a sysadmin wishes to monitor module unloading with a syscall rule such as:
 -a always,exit -F arch=x86_64 -S delete_module -F key=mod-unload
the SYSCALL record doesn't tell us what module was requested for unloading.

Use the new KERN_MODULE auxiliary record to record it.
The SYSCALL record result code will list the return code.

See: https://github.com/linux-audit/audit-kernel/issues/37
    https://github.com/linux-audit/audit-kernel/issues/7
    https://github.com/linux-audit/audit-kernel/wiki/RFE-Module-Load-Record-Format

Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
---
 kernel/module.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/module.c b/kernel/module.c
index 5432dbe..633f6da 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -943,6 +943,8 @@ SYSCALL_DEFINE2(delete_module, const char __user *, name_user,
 		return -EFAULT;
 	name[MODULE_NAME_LEN-1] = '\0';
 
+	audit_log_kern_module(name);
+
 	if (mutex_lock_interruptible(&module_mutex) != 0)
 		return -EINTR;
 
-- 
1.7.1

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] audit: log module name on delete_module
  2017-03-12  2:24 [PATCH v2] audit: log module name on delete_module Richard Guy Briggs
@ 2017-03-13 14:16 ` Paul Moore
  2017-03-13 16:31   ` Jessica Yu
  0 siblings, 1 reply; 4+ messages in thread
From: Paul Moore @ 2017-03-13 14:16 UTC (permalink / raw)
  To: Jessica Yu; +Cc: Richard Guy Briggs, linux-kernel, linux-audit

On Sat, Mar 11, 2017 at 9:24 PM, Richard Guy Briggs <rgb@redhat.com> wrote:
> When a sysadmin wishes to monitor module unloading with a syscall rule such as:
>  -a always,exit -F arch=x86_64 -S delete_module -F key=mod-unload
> the SYSCALL record doesn't tell us what module was requested for unloading.
>
> Use the new KERN_MODULE auxiliary record to record it.
> The SYSCALL record result code will list the return code.
>
> See: https://github.com/linux-audit/audit-kernel/issues/37
>     https://github.com/linux-audit/audit-kernel/issues/7
>     https://github.com/linux-audit/audit-kernel/wiki/RFE-Module-Load-Record-Format
>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
>  kernel/module.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Jessica?  If there are no objections to this patch on your side I'll
merge this into the audit/next tree.

> diff --git a/kernel/module.c b/kernel/module.c
> index 5432dbe..633f6da 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -943,6 +943,8 @@ SYSCALL_DEFINE2(delete_module, const char __user *, name_user,
>                 return -EFAULT;
>         name[MODULE_NAME_LEN-1] = '\0';
>
> +       audit_log_kern_module(name);
> +
>         if (mutex_lock_interruptible(&module_mutex) != 0)
>                 return -EINTR;
>
> --
> 1.7.1
>
> --
> Linux-audit mailing list
> Linux-audit@redhat.com
> https://www.redhat.com/mailman/listinfo/linux-audit

-- 
paul moore
www.paul-moore.com

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] audit: log module name on delete_module
  2017-03-13 14:16 ` Paul Moore
@ 2017-03-13 16:31   ` Jessica Yu
  2017-03-15 19:48     ` Paul Moore
  0 siblings, 1 reply; 4+ messages in thread
From: Jessica Yu @ 2017-03-13 16:31 UTC (permalink / raw)
  To: Paul Moore; +Cc: Richard Guy Briggs, linux-kernel, linux-audit

+++ Paul Moore [13/03/17 10:16 -0400]:
>On Sat, Mar 11, 2017 at 9:24 PM, Richard Guy Briggs <rgb@redhat.com> wrote:
>> When a sysadmin wishes to monitor module unloading with a syscall rule such as:
>>  -a always,exit -F arch=x86_64 -S delete_module -F key=mod-unload
>> the SYSCALL record doesn't tell us what module was requested for unloading.
>>
>> Use the new KERN_MODULE auxiliary record to record it.
>> The SYSCALL record result code will list the return code.
>>
>> See: https://github.com/linux-audit/audit-kernel/issues/37
>>     https://github.com/linux-audit/audit-kernel/issues/7
>>     https://github.com/linux-audit/audit-kernel/wiki/RFE-Module-Load-Record-Format
>>
>> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
>> ---
>>  kernel/module.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>
>Jessica?  If there are no objections to this patch on your side I'll
>merge this into the audit/next tree.

Looks good to me:

Acked-by: Jessica Yu <jeyu@redhat.com>

>> diff --git a/kernel/module.c b/kernel/module.c
>> index 5432dbe..633f6da 100644
>> --- a/kernel/module.c
>> +++ b/kernel/module.c
>> @@ -943,6 +943,8 @@ SYSCALL_DEFINE2(delete_module, const char __user *, name_user,
>>                 return -EFAULT;
>>         name[MODULE_NAME_LEN-1] = '\0';
>>
>> +       audit_log_kern_module(name);
>> +
>>         if (mutex_lock_interruptible(&module_mutex) != 0)
>>                 return -EINTR;
>>
>> --
>> 1.7.1
>>
>> --
>> Linux-audit mailing list
>> Linux-audit@redhat.com
>> https://www.redhat.com/mailman/listinfo/linux-audit
>
>-- 
>paul moore
>www.paul-moore.com

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] audit: log module name on delete_module
  2017-03-13 16:31   ` Jessica Yu
@ 2017-03-15 19:48     ` Paul Moore
  0 siblings, 0 replies; 4+ messages in thread
From: Paul Moore @ 2017-03-15 19:48 UTC (permalink / raw)
  To: Jessica Yu; +Cc: Richard Guy Briggs, linux-kernel, linux-audit

On Mon, Mar 13, 2017 at 12:31 PM, Jessica Yu <jeyu@redhat.com> wrote:
> +++ Paul Moore [13/03/17 10:16 -0400]:
>>
>> On Sat, Mar 11, 2017 at 9:24 PM, Richard Guy Briggs <rgb@redhat.com>
>> wrote:
>>>
>>> When a sysadmin wishes to monitor module unloading with a syscall rule
>>> such as:
>>>  -a always,exit -F arch=x86_64 -S delete_module -F key=mod-unload
>>> the SYSCALL record doesn't tell us what module was requested for
>>> unloading.
>>>
>>> Use the new KERN_MODULE auxiliary record to record it.
>>> The SYSCALL record result code will list the return code.
>>>
>>> See: https://github.com/linux-audit/audit-kernel/issues/37
>>>     https://github.com/linux-audit/audit-kernel/issues/7
>>>
>>> https://github.com/linux-audit/audit-kernel/wiki/RFE-Module-Load-Record-Format
>>>
>>> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
>>> ---
>>>  kernel/module.c |    2 ++
>>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>>
>> Jessica?  If there are no objections to this patch on your side I'll
>> merge this into the audit/next tree.
>
>
> Looks good to me:
>
> Acked-by: Jessica Yu <jeyu@redhat.com>

Merged, thanks everyone.

-- 
paul moore
www.paul-moore.com

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-15 19:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-12  2:24 [PATCH v2] audit: log module name on delete_module Richard Guy Briggs
2017-03-13 14:16 ` Paul Moore
2017-03-13 16:31   ` Jessica Yu
2017-03-15 19:48     ` Paul Moore

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®