From: Taniya Das <taniya.das@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: videocc-glymur: Constify qcom_cc_desc
Date: Tue, 31 Mar 2026 14:45:51 +0530 [thread overview]
Message-ID: <f346e3f0-9373-4b40-a5ca-cebec6c4da71@oss.qualcomm.com> (raw)
In-Reply-To: <20260331085521.37337-2-krzysztof.kozlowski@oss.qualcomm.com>
On 3/31/2026 2:25 PM, Krzysztof Kozlowski wrote:
> Static 'struct qcom_cc_desc' is not modified by drivers and can be made
> const for code safety.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
> ---
>
> Drivers for SM8750 video cc had the same issue. It would be nice if new
> code is being built on top of UPSTREAM code, not downstream.
> ---
> drivers/clk/qcom/videocc-glymur.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/videocc-glymur.c b/drivers/clk/qcom/videocc-glymur.c
> index bb3aae6b8396..ea20605dd1e5 100644
> --- a/drivers/clk/qcom/videocc-glymur.c
> +++ b/drivers/clk/qcom/videocc-glymur.c
> @@ -495,7 +495,7 @@ static struct qcom_cc_driver_data video_cc_glymur_driver_data = {
> .clk_regs_configure = clk_glymur_regs_configure,
> };
>
> -static struct qcom_cc_desc video_cc_glymur_desc = {
> +static const struct qcom_cc_desc video_cc_glymur_desc = {
> .config = &video_cc_glymur_regmap_config,
> .clks = video_cc_glymur_clocks,
> .num_clks = ARRAY_SIZE(video_cc_glymur_clocks),
Reviewed-by: Taniya Das <taniya.das@oss.qualcomm.com>
--
Thanks,
Taniya Das
next prev parent reply other threads:[~2026-03-31 9:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 8:55 Krzysztof Kozlowski
2026-03-31 8:59 ` Konrad Dybcio
2026-03-31 9:20 ` Taniya Das
2026-03-31 11:34 ` Krzysztof Kozlowski
2026-03-31 9:15 ` Taniya Das [this message]
2026-04-05 19:40 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f346e3f0-9373-4b40-a5ca-cebec6c4da71@oss.qualcomm.com \
--to=taniya.das@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®