"x86/boot/compressed/64: Prepare trampoline memory" breaks boot on Zotac CI-321

"x86/boot/compressed/64: Prepare trampoline memory" breaks boot on Zotac CI-321

[Heiner Kallweit]

Recently my Mini PC Zotac CI-321 started to reboot immediately before
anything was written to the console.

Bisecting lead to b91993a87aff "x86/boot/compressed/64: Prepare
trampoline memory" being the change breaking boot.

If you need any more information, please let me know.

Rgds, Heiner

Re: "x86/boot/compressed/64: Prepare trampoline memory" breaks boot on Zotac CI-321

[Heiner Kallweit]

Am 03.03.2018 um 00:50 schrieb Dexuan-Linux Cui:
> On Fri, Mar 2, 2018 at 12:57 PM, Heiner Kallweit <hkallweit1@gmail.com <mailto:hkallweit1@gmail.com>> wrote:
> 
>     Recently my Mini PC Zotac CI-321 started to reboot immediately before
>     anything was written to the console.
> 
>     Bisecting lead to b91993a87aff "x86/boot/compressed/64: Prepare
>     trampoline memory" being the change breaking boot.
> 
>     If you need any more information, please let me know.
> 
>     Rgds, Heiner
> 
> 
> This may fix the issue: https://lkml.org/lkml/2018/2/13/668
> 
> Kirill posted a v2 patchset 3 days ago and I suppose the patchset should include the fix.
> 
Thanks for the link. I bisected based on the latest next kernel including
v2 of the patchset (IOW - the potential fix is included already).

So it seems that the proposed fix fixes certain scenarios but not all.

> -- Dexuan

Using the content of arch/x86/boot/compressed from Feb 9th the system boots
and dmesg looks like this (HTH). CPU is a Celeron 2961Y, distro is Arch Linux.


[Mar 3 01:04] microcode: microcode updated early to revision 0x21, date = 2017-11-20
[  +0.000000] Linux version 4.16.0-rc3-next-20180302+ (root@zotac) (gcc version 7.3.0 (GCC)) #3 SMP Sat Mar 3 00:53:52 CET 2018
[  +0.000000] Command line: root=/dev/sda2 rw initrd=/intel-ucode.img initrd=/initramfs-linux.img
[  +0.000000] Intel Spectre v2 broken microcode detected; disabling Speculation Control
[  +0.000000] x86/fpu: Supporting XSAVE feature 0x001: 'x87 floating point registers'
[  +0.000000] x86/fpu: Supporting XSAVE feature 0x002: 'SSE registers'
[  +0.000000] x86/fpu: Enabled xstate features 0x3, context size is 576 bytes, using 'standard' format.
[  +0.000000] e820: BIOS-provided physical RAM map:
[  +0.000000] BIOS-e820: [mem 0x0000000000000000-0x0000000000057fff] usable
[  +0.000000] BIOS-e820: [mem 0x0000000000058000-0x0000000000058fff] reserved
[  +0.000000] BIOS-e820: [mem 0x0000000000059000-0x000000000009dfff] usable
[  +0.000000] BIOS-e820: [mem 0x000000000009e000-0x000000000009ffff] reserved
[  +0.000000] BIOS-e820: [mem 0x0000000000100000-0x00000000cb2ddfff] usable
[  +0.000000] BIOS-e820: [mem 0x00000000cb2de000-0x00000000cb2e4fff] ACPI NVS
[  +0.000000] BIOS-e820: [mem 0x00000000cb2e5000-0x00000000cba53fff] usable
[  +0.000000] BIOS-e820: [mem 0x00000000cba54000-0x00000000cbcfefff] reserved
[  +0.000000] BIOS-e820: [mem 0x00000000cbcff000-0x00000000db778fff] usable
[  +0.000000] BIOS-e820: [mem 0x00000000db779000-0x00000000db82efff] reserved
[  +0.000000] BIOS-e820: [mem 0x00000000db82f000-0x00000000db87dfff] usable
[  +0.000000] BIOS-e820: [mem 0x00000000db87e000-0x00000000db9acfff] ACPI NVS
[  +0.000000] BIOS-e820: [mem 0x00000000db9ad000-0x00000000dbffefff] reserved
[  +0.000000] BIOS-e820: [mem 0x00000000dbfff000-0x00000000dbffffff] usable
[  +0.000000] BIOS-e820: [mem 0x00000000dd000000-0x00000000df1fffff] reserved
[  +0.000000] BIOS-e820: [mem 0x00000000f8000000-0x00000000fbffffff] reserved
[  +0.000000] BIOS-e820: [mem 0x00000000fec00000-0x00000000fec00fff] reserved
[  +0.000000] BIOS-e820: [mem 0x00000000fed00000-0x00000000fed03fff] reserved
[  +0.000000] BIOS-e820: [mem 0x00000000fed1c000-0x00000000fed1ffff] reserved
[  +0.000000] BIOS-e820: [mem 0x00000000fee00000-0x00000000fee00fff] reserved
[  +0.000000] BIOS-e820: [mem 0x00000000ff000000-0x00000000ffffffff] reserved
[  +0.000000] BIOS-e820: [mem 0x0000000100000000-0x000000011fdfffff] usable
[  +0.000000] NX (Execute Disable) protection: active
[  +0.000000] efi: EFI v2.31 by American Megatrends
[  +0.000000] efi:  ESRT=0xdbf84998  ACPI=0xdb980000  ACPI 2.0=0xdb980000  SMBIOS=0xdbf84598
[  +0.000000] secureboot: Secure boot disabled
[  +0.000000] random: fast init done
[  +0.000000] SMBIOS 2.8 present.
[  +0.000000] DMI: ZOTAC ZBOX-CI321NANO/ZBOX-CI321NANO, BIOS B246P105 06/01/2015

Re: "x86/boot/compressed/64: Prepare trampoline memory" breaks boot on Zotac CI-321

[Ingo Molnar]

* Heiner Kallweit <hkallweit1@gmail.com> wrote:

> Am 03.03.2018 um 00:50 schrieb Dexuan-Linux Cui:
> > On Fri, Mar 2, 2018 at 12:57 PM, Heiner Kallweit <hkallweit1@gmail.com <mailto:hkallweit1@gmail.com>> wrote:
> > 
> >     Recently my Mini PC Zotac CI-321 started to reboot immediately before
> >     anything was written to the console.
> > 
> >     Bisecting lead to b91993a87aff "x86/boot/compressed/64: Prepare
> >     trampoline memory" being the change breaking boot.
> > 
> >     If you need any more information, please let me know.
> > 
> >     Rgds, Heiner
> > 
> > 
> > This may fix the issue: https://lkml.org/lkml/2018/2/13/668
> > 
> > Kirill posted a v2 patchset 3 days ago and I suppose the patchset should include the fix.
> > 
> Thanks for the link. I bisected based on the latest next kernel including
> v2 of the patchset (IOW - the potential fix is included already).

Are you sure? b91993a87aff is the old patch-set - which I just removed from -next 
and which should thus be gone in the Monday iteration of -next.

I have not merged v2 in -tip yet, did it get applied via some other tree?

Thanks,

	Ingo

Re: "x86/boot/compressed/64: Prepare trampoline memory" breaks boot on Zotac CI-321

[Heiner Kallweit]

Am 03.03.2018 um 11:02 schrieb Ingo Molnar:
> 
> * Heiner Kallweit <hkallweit1@gmail.com> wrote:
> 
>> Am 03.03.2018 um 00:50 schrieb Dexuan-Linux Cui:
>>> On Fri, Mar 2, 2018 at 12:57 PM, Heiner Kallweit <hkallweit1@gmail.com <mailto:hkallweit1@gmail.com>> wrote:
>>>
>>>     Recently my Mini PC Zotac CI-321 started to reboot immediately before
>>>     anything was written to the console.
>>>
>>>     Bisecting lead to b91993a87aff "x86/boot/compressed/64: Prepare
>>>     trampoline memory" being the change breaking boot.
>>>
>>>     If you need any more information, please let me know.
>>>
>>>     Rgds, Heiner
>>>
>>>
>>> This may fix the issue: https://lkml.org/lkml/2018/2/13/668
>>>
>>> Kirill posted a v2 patchset 3 days ago and I suppose the patchset should include the fix.
>>>
>> Thanks for the link. I bisected based on the latest next kernel including
>> v2 of the patchset (IOW - the potential fix is included already).
> 
> Are you sure? b91993a87aff is the old patch-set - which I just removed from -next 
> and which should thus be gone in the Monday iteration of -next.
> 
> I have not merged v2 in -tip yet, did it get applied via some other tree?
> 
> Thanks,
> 
> 	Ingo
> 
I wanted to apply the fix mentioned in the link but found that the statement was movq already.
Therefore my (most likely false) understanding that it's v2.
I'll re-test once v2 is out and let you know.

Rgds, Heiner


 diff --git a/arch/x86/boot/compressed/head_64.S b/arch/x86/boot/compressed/head_64.S
 index 70b30f2bc9e0..99a0e7993252 100644
 --- a/arch/x86/boot/compressed/head_64.S
 +++ b/arch/x86/boot/compressed/head_64.S
 @@ -332,7 +332,7 @@ ENTRY(startup_64)
 
  	/* Make sure we have GDT with 32-bit code segment */
  	leaq	gdt(%rip), %rax
 -	movl	%eax, gdt64+2(%rip)
 +	movq	%rax, gdt64+2(%rip)
  	lgdt	gdt64(%rip)
 
  	/*
 -- 
  Kirill A. Shutemov

Re: "x86/boot/compressed/64: Prepare trampoline memory" breaks boot on Zotac CI-321

[Kirill A. Shutemov]

On Sat, Mar 03, 2018 at 12:46:28PM +0100, Heiner Kallweit wrote:
> Am 03.03.2018 um 11:02 schrieb Ingo Molnar:
> > 
> > * Heiner Kallweit <hkallweit1@gmail.com> wrote:
> > 
> >> Am 03.03.2018 um 00:50 schrieb Dexuan-Linux Cui:
> >>> On Fri, Mar 2, 2018 at 12:57 PM, Heiner Kallweit <hkallweit1@gmail.com <mailto:hkallweit1@gmail.com>> wrote:
> >>>
> >>>     Recently my Mini PC Zotac CI-321 started to reboot immediately before
> >>>     anything was written to the console.
> >>>
> >>>     Bisecting lead to b91993a87aff "x86/boot/compressed/64: Prepare
> >>>     trampoline memory" being the change breaking boot.
> >>>
> >>>     If you need any more information, please let me know.
> >>>
> >>>     Rgds, Heiner
> >>>
> >>>
> >>> This may fix the issue: https://lkml.org/lkml/2018/2/13/668
> >>>
> >>> Kirill posted a v2 patchset 3 days ago and I suppose the patchset should include the fix.
> >>>
> >> Thanks for the link. I bisected based on the latest next kernel including
> >> v2 of the patchset (IOW - the potential fix is included already).
> > 
> > Are you sure? b91993a87aff is the old patch-set - which I just removed from -next 
> > and which should thus be gone in the Monday iteration of -next.
> > 
> > I have not merged v2 in -tip yet, did it get applied via some other tree?
> > 
> > Thanks,
> > 
> > 	Ingo
> > 
> I wanted to apply the fix mentioned in the link but found that the statement was movq already.
> Therefore my (most likely false) understanding that it's v2.
> I'll re-test once v2 is out and let you know.

movq fix is unrelated to the problem.

Please check if current linux-next plus this patchset causes a problem for
you:

http://lkml.kernel.org/r/20180227154217.69347-1-kirill.shutemov@linux.intel.com

-- 
 Kirill A. Shutemov

Re: "x86/boot/compressed/64: Prepare trampoline memory" breaks boot on Zotac CI-321

[Heiner Kallweit]

Am 05.03.2018 um 09:19 schrieb Kirill A. Shutemov:
> On Sat, Mar 03, 2018 at 12:46:28PM +0100, Heiner Kallweit wrote:
>> Am 03.03.2018 um 11:02 schrieb Ingo Molnar:
>>>
>>> * Heiner Kallweit <hkallweit1@gmail.com> wrote:
>>>
>>>> Am 03.03.2018 um 00:50 schrieb Dexuan-Linux Cui:
>>>>> On Fri, Mar 2, 2018 at 12:57 PM, Heiner Kallweit <hkallweit1@gmail.com <mailto:hkallweit1@gmail.com>> wrote:
>>>>>
>>>>>     Recently my Mini PC Zotac CI-321 started to reboot immediately before
>>>>>     anything was written to the console.
>>>>>
>>>>>     Bisecting lead to b91993a87aff "x86/boot/compressed/64: Prepare
>>>>>     trampoline memory" being the change breaking boot.
>>>>>
>>>>>     If you need any more information, please let me know.
>>>>>
>>>>>     Rgds, Heiner
>>>>>
>>>>>
>>>>> This may fix the issue: https://lkml.org/lkml/2018/2/13/668
>>>>>
>>>>> Kirill posted a v2 patchset 3 days ago and I suppose the patchset should include the fix.
>>>>>
>>>> Thanks for the link. I bisected based on the latest next kernel including
>>>> v2 of the patchset (IOW - the potential fix is included already).
>>>
>>> Are you sure? b91993a87aff is the old patch-set - which I just removed from -next 
>>> and which should thus be gone in the Monday iteration of -next.
>>>
>>> I have not merged v2 in -tip yet, did it get applied via some other tree?
>>>
>>> Thanks,
>>>
>>> 	Ingo
>>>
>> I wanted to apply the fix mentioned in the link but found that the statement was movq already.
>> Therefore my (most likely false) understanding that it's v2.
>> I'll re-test once v2 is out and let you know.
> 
> movq fix is unrelated to the problem.
> 
> Please check if current linux-next plus this patchset causes a problem for
> you:
> 
> http://lkml.kernel.org/r/20180227154217.69347-1-kirill.shutemov@linux.intel.com
> 

linux-next from today boots fine with the patchset applied.

Rgds, Heiner

Re: "x86/boot/compressed/64: Prepare trampoline memory" breaks boot on Zotac CI-321

[Kirill A. Shutemov]

On Mon, Mar 05, 2018 at 07:57:06PM +0100, Heiner Kallweit wrote:
> Am 05.03.2018 um 09:19 schrieb Kirill A. Shutemov:
> > On Sat, Mar 03, 2018 at 12:46:28PM +0100, Heiner Kallweit wrote:
> >> I wanted to apply the fix mentioned in the link but found that the statement was movq already.
> >> Therefore my (most likely false) understanding that it's v2.
> >> I'll re-test once v2 is out and let you know.
> > 
> > movq fix is unrelated to the problem.
> > 
> > Please check if current linux-next plus this patchset causes a problem for
> > you:
> > 
> > http://lkml.kernel.org/r/20180227154217.69347-1-kirill.shutemov@linux.intel.com
> > 
> 
> linux-next from today boots fine with the patchset applied.

Thanks for testing!

Ingo, is there anything else I need to do for the patchset to be applied?

-- 
 Kirill A. Shutemov