From: Vitaly Lipatov <lav@etersoft.ru>
To: Jeff Layton <jlayton@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, hch@lst.de, bfields@fieldses.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fcntl: don't cap l_start and l_end values for F_GETLK64 in compat syscall
Date: Wed, 15 Nov 2017 16:36:43 +0300 [thread overview]
Message-ID: <f3c22b98e9c5da1b873829d5271462c6@etersoft.ru> (raw)
In-Reply-To: <20171115131750.27717-1-jlayton@kernel.org>
Jeff Layton писал 15.11.17 16:17:
> From: Jeff Layton <jlayton@redhat.com>
>
> Currently, we're capping the values too low in the F_GETLK64 case. The
> fields in that structure are 64-bit values, so we shouldn't need to any
> sort of fixup there.
>
> Make sure we check that assumption at build time in the future however
> by ensuring that the sizes we're copying will fit.
Nice fix.
The only question I do not know answer is what is purpose of
COMPAT_LOFF_T_MAX macro?
--
С уважением,
Виталий Липатов,
Etersoft
prev parent reply other threads:[~2017-11-15 13:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 13:17 Jeff Layton
2017-11-15 13:36 ` Vitaly Lipatov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3c22b98e9c5da1b873829d5271462c6@etersoft.ru \
--to=lav@etersoft.ru \
--cc=bfields@fieldses.org \
--cc=hch@lst.de \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®