* [PATCH v1] drivers:block:Fix the NULL vs IS_ERR() bug for debugfs_create_dir()
@ 2024-08-21 6:49 Yang Ruibin
2024-08-22 9:27 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: Yang Ruibin @ 2024-08-21 6:49 UTC (permalink / raw)
To: linux-block, Jens Axboe, linux-kernel; +Cc: opensource.kernel, Yang Ruibin
The debugfs_create_dir() function returns error pointers.
It never returns NULL. So use IS_ERR() to check it.
Signed-off-by: Yang Ruibin <11162571@vivo.com>
---
drivers/block/pktcdvd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index 7cece5884b9c..030b7a063a0b 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -498,7 +498,7 @@ static void pkt_debugfs_dev_new(struct pktcdvd_device *pd)
if (!pkt_debugfs_root)
return;
pd->dfs_d_root = debugfs_create_dir(pd->disk->disk_name, pkt_debugfs_root);
- if (!pd->dfs_d_root)
+ if (IS_ERR(pd->dfs_d_root))
return;
pd->dfs_f_info = debugfs_create_file("info", 0444, pd->dfs_d_root,
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v1] drivers:block:Fix the NULL vs IS_ERR() bug for debugfs_create_dir()
2024-08-21 6:49 [PATCH v1] drivers:block:Fix the NULL vs IS_ERR() bug for debugfs_create_dir() Yang Ruibin
@ 2024-08-22 9:27 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2024-08-22 9:27 UTC (permalink / raw)
To: Yang Ruibin, linux-block, Jens Axboe, linux-kernel; +Cc: opensource.kernel
On 8/21/24 15:49, Yang Ruibin wrote:
> The debugfs_create_dir() function returns error pointers.
> It never returns NULL. So use IS_ERR() to check it.
...to check its return value.
And the patch title could be better. May be something like:
pktcdvd: Use IS_ERR() to check debugfs_create_dir() return value
>
> Signed-off-by: Yang Ruibin <11162571@vivo.com>
This needs a Fixes tag.
> ---
> drivers/block/pktcdvd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
> index 7cece5884b9c..030b7a063a0b 100644
> --- a/drivers/block/pktcdvd.c
> +++ b/drivers/block/pktcdvd.c
> @@ -498,7 +498,7 @@ static void pkt_debugfs_dev_new(struct pktcdvd_device *pd)
> if (!pkt_debugfs_root)
> return;
> pd->dfs_d_root = debugfs_create_dir(pd->disk->disk_name, pkt_debugfs_root);
> - if (!pd->dfs_d_root)
> + if (IS_ERR(pd->dfs_d_root))
> return;
>
> pd->dfs_f_info = debugfs_create_file("info", 0444, pd->dfs_d_root,
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-22 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-21 6:49 [PATCH v1] drivers:block:Fix the NULL vs IS_ERR() bug for debugfs_create_dir() Yang Ruibin
2024-08-22 9:27 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®