mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Armin Wolf <W_Armin@gmx.de>
To: "Brian Mak" <bmak@nvidia.com>, "Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Kurt Borja" <kuurtb@gmail.com>,
	"Stuart Hayes" <stuart.w.hayes@gmail.com>,
	"Matthew Garrett" <mjg59@srcf.ucam.org>,
	"Pali Rohár" <pali@kernel.org>,
	"Lyndon Sanche" <lsanche@lyndeno.ca>,
	"Prasanth Ksr" <prasanth.ksr@dell.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] platform: dell: smbios: Add quirk for non-functional calling interface
Date: Sat, 21 Nov 2026 14:49:25 +0100	[thread overview]
Message-ID: <f3dc7e25-9c22-4b1d-9555-e83db82d05a1@gmx.de> (raw)
In-Reply-To: <20261121000556.173028-7-bmak@nvidia.com>

Am 21.11.26 um 01:05 schrieb Brian Mak:

> On Dell RTX Spark laptops, the SMBIOS calling interface completes every
> request with an all-zero buffer, even for requests that should fail.
> Drivers that rely on it, such as dell-laptop and dell-pc, end up
> reporting bogus state, like battery charge modes and thermal modes.
>
> Add a DMI quirk list for platforms with a non-functional calling
> interface, and export dell_smbios_calls_functional() so that consumers
> can avoid loading on them. dell-smbios itself still loads, as dell-wmi
> depends on it.

Hi,

do you have access to such a machine? I would be _very_ interested in the output
of acpidump on this machine, maybe this could be an issue with ACPICA.

Alternatively, maybe the wrong backend get selected. Currently the dell-smbios-smm
backend will try to read a specific token in test_wsmt_enabled() to determine if
the WSMT ACPI table is active. This might not work on arm64 machines, so maybe parsing
the real WSMT ACPI table would fix this problem?

Thanks,
Armin Wolf

> Signed-off-by: Brian Mak <bmak@nvidia.com>
> ---
>   drivers/platform/dell/dell-smbios-base.c | 22 ++++++++++++++++++++++
>   drivers/platform/dell/dell-smbios.h      |  1 +
>   2 files changed, 23 insertions(+)
>
> diff --git a/drivers/platform/dell/dell-smbios-base.c b/drivers/platform/dell/dell-smbios-base.c
> index c8e93c12c445..e07cbb0e8a6a 100644
> --- a/drivers/platform/dell/dell-smbios-base.c
> +++ b/drivers/platform/dell/dell-smbios-base.c
> @@ -390,6 +390,28 @@ bool dell_smbios_class_is_supported(u16 class)
>   }
>   EXPORT_SYMBOL_GPL(dell_smbios_class_is_supported);
>   
> +/*
> + * Some Dell firmware completes its proprietary SMBIOS calls with all zeroes,
> + * so any value read through it (tokens, battery and thermal modes)
> + * is invalid.
> + */
> +static const struct dmi_system_id dell_smbios_calls_broken_list[] = {
> +	{
> +		.ident = "Dell XPS 16 DX16263",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "XPS 16 DX16263"),
> +		},
> +	},
> +	{ }
> +};
> +
> +bool dell_smbios_calls_functional(void)
> +{
> +	return !dmi_check_system(dell_smbios_calls_broken_list);
> +}
> +EXPORT_SYMBOL_GPL(dell_smbios_calls_functional);
> +
>   static void __init parse_da_table(const struct dmi_header *dm)
>   {
>   	/* Final token is a terminator, so we don't want to copy it */
> diff --git a/drivers/platform/dell/dell-smbios.h b/drivers/platform/dell/dell-smbios.h
> index 1e64803bc00d..26f54364ffde 100644
> --- a/drivers/platform/dell/dell-smbios.h
> +++ b/drivers/platform/dell/dell-smbios.h
> @@ -89,6 +89,7 @@ int dell_laptop_register_notifier(struct notifier_block *nb);
>   int dell_laptop_unregister_notifier(struct notifier_block *nb);
>   void dell_laptop_call_notifier(unsigned long action, void *data);
>   bool dell_smbios_class_is_supported(u16 class);
> +bool dell_smbios_calls_functional(void);
>   
>   /* for the supported backends */
>   #ifdef CONFIG_DELL_SMBIOS_WMI

  parent reply	other threads:[~2026-11-21 13:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21  0:05 [PATCH 0/8] platform: dell: Move out of x86 and support Dell XPS 16 Creator Edition Brian Mak
2026-11-21  0:05 ` [PATCH 1/8] platform/x86: dell: Make uart-backlight x86 only Brian Mak
2026-11-21  1:36   ` Randy Dunlap
2026-11-21  1:36     ` Randy Dunlap
2026-11-21  0:05 ` [PATCH 2/8] platform: dell: Move out of x86 directory Brian Mak
2026-11-21 10:05   ` kernel test robot
2026-11-21  0:05 ` [PATCH 3/8] MAINTAINERS: Add Dell platform drivers entry Brian Mak
2026-11-21  0:05 ` [PATCH 4/8] platform: dell: Allow DELL_LAPTOP to be arch-independent Brian Mak
2026-11-21  0:48   ` Pali Rohár
2026-11-21  1:38   ` Randy Dunlap
2026-11-21  0:05 ` [PATCH 5/8] platform: dell: smbios-wmi: Fix probe on RTX Spark Brian Mak
2026-11-21 13:44   ` Armin Wolf
2026-11-21  0:05 ` [PATCH 6/8] platform: dell: smbios: Add quirk for non-functional calling interface Brian Mak
2026-11-21  0:38   ` Pali Rohár
2026-11-21  0:45     ` Brian Mak
2026-11-21  0:51       ` Pali Rohár
2026-11-21 13:49   ` Armin Wolf [this message]
2026-11-21  0:05 ` [PATCH 7/8] platform: dell: laptop: Don't load if SMBIOS calls are non-functional Brian Mak
2026-11-21  0:05 ` [PATCH 8/8] platform: dell: pc: " Brian Mak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3dc7e25-9c22-4b1d-9555-e83db82d05a1@gmx.de \
    --to=w_armin@gmx.de \
    --cc=Dell.Client.Kernel@dell.com \
    --cc=bmak@nvidia.com \
    --cc=corbet@lwn.net \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=kuurtb@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lsanche@lyndeno.ca \
    --cc=mjg59@srcf.ucam.org \
    --cc=pali@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=prasanth.ksr@dell.com \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=stuart.w.hayes@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®