From: Mike Lothian <mike@fireburn.co.uk>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Matthias Hopf <mhopf@suse.de>,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: Samsung Backlight Patch
Date: Thu, 8 Oct 2009 00:31:51 +0100 [thread overview]
Message-ID: <f3f71ab90910071631g2ffb4796u6a3a370252c4cf92@mail.gmail.com> (raw)
In-Reply-To: <20091007225828.GA7892@kroah.com>
2009/10/7 Greg KH <greg@kroah.com>:
> On Wed, Oct 07, 2009 at 10:31:44PM +0100, Mike Lothian wrote:
>> 2009/10/7 Greg KH <greg@kroah.com>:
>> > On Wed, Oct 07, 2009 at 10:14:37PM +0100, Mike Lothian wrote:
>> >> Hi
>> >>
>> >> I was hoping the following patch could be included in 2.6.32 so it
>> >> would hopefully end up in the next round of distros
>> >>
>> >> It adds backlight support for some Samsung laptops
>> >
>> > You seem to have lost the original authorship of this patch, and not
>> > included your signed-off-by for it.
>> >
>> > Which means it can't be applied :(
>> >
>> > thanks,
>> >
>> > greg k-h
>> >
>>
>> It definitely has +MODULE_AUTHOR("Greg Kroah-Hartman
>> <gregkh@suse.de>"); at the bottom
>>
>> I certainly wasn't trying to steal credit for your work
>
> I mean on the patch, when submitting it, you need a:
> From: Greg Kroah-Hartman <gregkh@suse.de>
>
> as the first line.
>
>> Who should sign it off?
>
> As I stated before, I can not sign off on this patch anymore, but I
> would like my authorship to remain. Someone needs to sign off on it...
>
>> I think there's a few other models that can be added to this patch too
>
> I do too.
>
> Note, if you look at the git tree I have for the driver, it is totally
> rewritten to not use a structure, and instead, use offsets properly.
> But it removed support for your laptop, which is not what you probably
> want :(
>
> thanks,
>
> greg k-h
>
What git tree?
next prev parent reply other threads:[~2009-10-07 23:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 21:14 Mike Lothian
2009-10-07 21:19 ` Greg KH
2009-10-07 21:31 ` Mike Lothian
2009-10-07 22:58 ` Greg KH
2009-10-07 23:31 ` Mike Lothian [this message]
2009-10-07 23:36 ` Greg KH
2009-10-07 23:52 ` Mike Lothian
2009-10-08 2:50 ` Greg KH
2009-10-11 9:04 ` Pavel Machek
2009-10-11 14:42 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3f71ab90910071631g2ffb4796u6a3a370252c4cf92@mail.gmail.com \
--to=mike@fireburn.co.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhopf@suse.de \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®