Re: Samsung Backlight Patch

[Mike Lothian <mike@fireburn.co.uk>]

2009/10/8 Greg KH <greg@kroah.com>:
> On Thu, Oct 08, 2009 at 12:31:51AM +0100, Mike Lothian wrote:
>> 2009/10/7 Greg KH <greg@kroah.com>:
>> > On Wed, Oct 07, 2009 at 10:31:44PM +0100, Mike Lothian wrote:
>> >> 2009/10/7 Greg KH <greg@kroah.com>:
>> >> > On Wed, Oct 07, 2009 at 10:14:37PM +0100, Mike Lothian wrote:
>> >> >> Hi
>> >> >>
>> >> >> I was hoping the following patch could be included in 2.6.32 so it
>> >> >> would hopefully end up in the next round of distros
>> >> >>
>> >> >> It adds backlight support for some Samsung laptops
>> >> >
>> >> > You seem to have lost the original authorship of this patch, and not
>> >> > included your signed-off-by for it.
>> >> >
>> >> > Which means it can't be applied :(
>> >> >
>> >> > thanks,
>> >> >
>> >> > greg k-h
>> >> >
>> >>
>> >> It definitely has +MODULE_AUTHOR("Greg Kroah-Hartman
>> >> <gregkh@suse.de>"); at the bottom
>> >>
>> >> I certainly wasn't trying to steal credit for your work
>> >
>> > I mean on the patch, when submitting it, you need a:
>> >        From: Greg Kroah-Hartman <gregkh@suse.de>
>> >
>> > as the first line.
>> >
>> >> Who should sign it off?
>> >
>> > As I stated before, I can not sign off on this patch anymore, but I
>> > would like my authorship to remain.  Someone needs to sign off on it...
>> >
>> >> I think there's a few other models that can be added to this patch too
>> >
>> > I do too.
>> >
>> > Note, if you look at the git tree I have for the driver, it is totally
>> > rewritten to not use a structure, and instead, use offsets properly.
>> > But it removed support for your laptop, which is not what you probably
>> > want :(
>> >
>> > thanks,
>> >
>> > greg k-h
>> >
>>
>> What git tree?
>
> http://github.com/gregkh/samsung-backlight
>
> Look at the "laptop" branch for the latest stuff.
>
> Also supports rfkill and "silent" mode for the N130/N128 machines.
>
> thanks,
>
> greg k-h
>

Tomorrow I'll try this updated patch with my laptop added and see if it works