From: Jeffrey E Altman <jaltman@auristor.com>
To: YueHaibing <yuehaibing@huawei.com>, dhowells@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org
Subject: Re: [PATCH -next] afs: remove unused variable 'afs_voltypes'
Date: Fri, 9 Aug 2019 13:40:53 -0400 [thread overview]
Message-ID: <f410b332-8df5-927e-6e68-2b2c7a32f92c@auristor.com> (raw)
In-Reply-To: <20190809084037.68784-1-yuehaibing@huawei.com>
[-- Attachment #1.1: Type: text/plain, Size: 1091 bytes --]
This is true but I believe afs_voltypes should be used in the
afs_put_volume() and afs_deactivate_volume() enter() tracing.
If it will not be used for those calls then removal is correct.
Jeffrey Altman
On 8/9/2019 4:40 AM, YueHaibing wrote:
> fs/afs/volume.c:15:26: warning:
> afs_voltypes defined but not used [-Wunused-const-variable=]
>
> It is not used since commit d2ddc776a458 ("afs: Overhaul
> volume and server record caching and fileserver rotation")
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> fs/afs/volume.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/afs/volume.c b/fs/afs/volume.c
> index 1a41430..92ca5e2 100644
> --- a/fs/afs/volume.c
> +++ b/fs/afs/volume.c
> @@ -12,8 +12,6 @@
> unsigned __read_mostly afs_volume_gc_delay = 10;
> unsigned __read_mostly afs_volume_record_life = 60 * 60;
>
> -static const char *const afs_voltypes[] = { "R/W", "R/O", "BAK" };
> -
> /*
> * Allocate a volume record and load it up from a vldb record.
> */
>
[-- Attachment #1.2: jaltman.vcf --]
[-- Type: text/x-vcard, Size: 283 bytes --]
begin:vcard
fn:Jeffrey Altman
n:Altman;Jeffrey
org:AuriStor, Inc.
adr:;;255 W 94TH ST STE 6B;New York;NY;10025-6985;United States
email;internet:jaltman@auristor.com
title:CEO
tel;work:+1-212-769-9018
url:https://www.linkedin.com/in/jeffreyaltman/
version:2.1
end:vcard
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4033 bytes --]
prev parent reply other threads:[~2019-08-09 17:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 8:40 YueHaibing
2019-08-09 17:40 ` Jeffrey E Altman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f410b332-8df5-927e-6e68-2b2c7a32f92c@auristor.com \
--to=jaltman@auristor.com \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®